Skip to content

Fix transition toggle & cancellation & delay#51439

Merged
Loirooriol merged 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_35978
Apr 8, 2025
Merged

Fix transition toggle & cancellation & delay#51439
Loirooriol merged 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_35978

Conversation

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

More details in Stylo PR: servo/stylo#145

Reviewed in servo/servo#35978

Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

@yezhizhen
Copy link
Copy Markdown
Contributor

The failing firefox-checks seems to have nothing to do with my change.

@servo-wpt-sync servo-wpt-sync force-pushed the servo_export_35978 branch 5 times, most recently from 5932140 to 02a7596 Compare March 25, 2025 16:18
@servo-wpt-sync servo-wpt-sync force-pushed the servo_export_35978 branch 6 times, most recently from a996a0f to 8e1a85f Compare April 5, 2025 03:58
@servo-wpt-sync servo-wpt-sync force-pushed the servo_export_35978 branch 5 times, most recently from 7cac696 to 63d661b Compare April 7, 2025 14:21
@servo-wpt-sync servo-wpt-sync added stale-servo-export PRs that were supposed to merge but were not able to do so. and removed do not merge yet labels Apr 7, 2025
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator Author

⛔ The downstream PR has merged (servo/servo#35978), but these changes could not be merged properly. Please address any CI issues and try to merge manually.

@Loirooriol Loirooriol force-pushed the servo_export_35978 branch from 63d661b to 2e57160 Compare April 7, 2025 15:44
@Loirooriol
Copy link
Copy Markdown
Contributor

@Ms2ger The stability check is failing for /css/css-transitions/CSSTransition-startTime.tentative.html, but that test isn't actually modified here. It's just that this adds a new helper in css/css-transitions/support/helper.js , and the problematic test uses this helper file. How to proceed?

Loirooriol added a commit to Loirooriol/web-platform-tests that referenced this pull request Apr 7, 2025
Loirooriol added a commit that referenced this pull request Apr 8, 2025
This test is not stable in Firefox, and thus prevents landing #51439.
Issue: #51881
@Loirooriol Loirooriol force-pushed the servo_export_35978 branch from 2e57160 to dbf3186 Compare April 8, 2025 14:55
@Loirooriol Loirooriol enabled auto-merge (rebase) April 8, 2025 14:55
@Loirooriol Loirooriol merged commit aa7014d into web-platform-tests:master Apr 8, 2025
17 checks passed
@Loirooriol Loirooriol deleted the servo_export_35978 branch April 8, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css-transitions servo-export stale-servo-export PRs that were supposed to merge but were not able to do so. wg-css

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants