Skip to content

script: implement ReadableByteStreamController#51210

Closed
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_35410
Closed

script: implement ReadableByteStreamController#51210
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_35410

Conversation

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

Part of servo/servo#34676

Reviewed in servo/servo#35410

Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

…ock for all descendants (web-platform-tests#35808)

* layout: Fix behavior of `transform-style: preserve-3d`

This makes `transform-style: preserve-3d` establish a containing block
for all descendants, as specified here:
<https://drafts.csswg.org/css-transforms-2/#transform-style-property>

Signed-off-by: Daniel Hast <[email protected]>

* layout: Check for transformable elements

Adds a new `is_transformable` helper method and use this in several other
methods, including the methods for whether the fragment establishes a
new stacking context or a containing block for all descendants.

Signed-off-by: Daniel Hast <[email protected]>

* Use generic green square reference for reftest.

Signed-off-by: Daniel Hast <[email protected]>

* layout: Fix stacking context & containing block checks.

Only the computed value of `transform-style` should be used to determine
whether the element establishes a stacking context and/or a containing
block, not the used value.

Signed-off-by: Daniel Hast <[email protected]>

* Update clip-no-stacking-context test expectation to pass.

Signed-off-by: Daniel Hast <[email protected]>

---------

Signed-off-by: Daniel Hast <[email protected]>
@servo-wpt-sync servo-wpt-sync added stale-servo-export PRs that were supposed to merge but were not able to do so. and removed do not merge yet labels Mar 10, 2025
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator Author

⛔ The downstream PR has merged (servo/servo#35410), but these changes could not be merged properly. Please address any CI issues and try to merge manually.

@Taym95
Copy link
Copy Markdown
Contributor

Taym95 commented Mar 10, 2025

This can be closed, was caused by merge issue!

@jdm jdm closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css-transforms servo-export stale-servo-export PRs that were supposed to merge but were not able to do so. wg-css

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants