script: implement ReadableByteStreamController#51210
Closed
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Closed
script: implement ReadableByteStreamController#51210servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
3 tasks
wpt-pr-bot
approved these changes
Mar 7, 2025
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
85ce07f to
471a6fb
Compare
…ock for all descendants (web-platform-tests#35808) * layout: Fix behavior of `transform-style: preserve-3d` This makes `transform-style: preserve-3d` establish a containing block for all descendants, as specified here: <https://drafts.csswg.org/css-transforms-2/#transform-style-property> Signed-off-by: Daniel Hast <[email protected]> * layout: Check for transformable elements Adds a new `is_transformable` helper method and use this in several other methods, including the methods for whether the fragment establishes a new stacking context or a containing block for all descendants. Signed-off-by: Daniel Hast <[email protected]> * Use generic green square reference for reftest. Signed-off-by: Daniel Hast <[email protected]> * layout: Fix stacking context & containing block checks. Only the computed value of `transform-style` should be used to determine whether the element establishes a stacking context and/or a containing block, not the used value. Signed-off-by: Daniel Hast <[email protected]> * Update clip-no-stacking-context test expectation to pass. Signed-off-by: Daniel Hast <[email protected]> --------- Signed-off-by: Daniel Hast <[email protected]>
471a6fb to
d2d7a9f
Compare
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#35410), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
Contributor
|
This can be closed, was caused by merge issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of servo/servo#34676
Reviewed in servo/servo#35410