Install fonts-noto-cjk for linux-wpt workflow#50853
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Feb 21, 2025
Merged
Install fonts-noto-cjk for linux-wpt workflow#50853servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
Conversation
5 tasks
wpt-pr-bot
approved these changes
Feb 21, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Collaborator
Author
|
🛠 Changes from the source pull request (servo/servo#35567) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
Signed-off-by: Xiaocheng Hu <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_35567
branch
from
7551859 to
954e4cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now CJK-related tests are not running properly as the characters are rendered as tofu.
This PR installs fonts-noto-cjk to fix it. Also:
css/css-fonts/size-adjust-unicode-range-system-fallback.htmlis a false pass, as the ref file depends on unsupportedsize-adjust. This PR removes the dependency to make it fail correctlyReviewed in servo/servo#35567