Make virtualenv use sysconfig to find paths#49649
Merged
gsnedders merged 1 commit intoweb-platform-tests:masterfrom Dec 12, 2024
Merged
Make virtualenv use sysconfig to find paths#49649gsnedders merged 1 commit intoweb-platform-tests:masterfrom
gsnedders merged 1 commit intoweb-platform-tests:masterfrom
Conversation
Instead of having our own copies of what we believe paths should be, or manually mutating what sysconfig returns for other variables, we should just delegate all of this to sysconfig in the standard way. This fixes web-platform-tests#49545, fixing Python 3.12.8 support, where sysconfig stopped overly caching certain variables, thus leading to oddities after we've rewritten sys.exec_prefix and sys.prefix.
jonathan-j-lee
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having our own copies of what we believe paths should be, or manually mutating what sysconfig returns for other variables, we should just delegate all of this to sysconfig in the standard way.
This fixes #49545, fixing Python 3.12.8 support, where sysconfig stopped overly caching certain variables, thus leading to oddities after we've rewritten sys.exec_prefix and sys.prefix.