Allow running testharness/testdriver/reftests in servodriver#49642
Merged
jdm merged 5 commits intoweb-platform-tests:masterfrom Dec 11, 2024
Merged
Allow running testharness/testdriver/reftests in servodriver#49642jdm merged 5 commits intoweb-platform-tests:masterfrom
jdm merged 5 commits intoweb-platform-tests:masterfrom
Conversation
4 tasks
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Dec 11, 2024
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_34550
branch
2 times, most recently
from
8b5260c to
1455df5
Compare
…tor classes. Signed-off-by: Josh Matthews <[email protected]>
…ftest executor. Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_34550
branch
from
1455df5 to
c9de2bf
Compare
servo-wpt-sync
added
stale-servo-export
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#34550), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
Contributor
|
Forcing merge because of #49545. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes remove all of the custom integration code for the servodriver WPT executor, making it a tiny wrapper around the upstream webdriver executors, which should improve maintainability going forward. This PR also implements support for missing webdriver commands that are sent by the webdriver test executor, and extends the JS->webdriver serialization to cover arbitrary JS objects which is required by the integration with testharnessreport.js.
Reviewed in servo/servo#34550