Add WPTs for named window lookup and BCG swap limits#49631
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
December 11, 2024 00:56
These tests verify the behaviour discussed here: whatwg/html#10818 While there is some implementation defined behaviour, we can add tests for the behaviour that's consistent between the major implementations, namely that proactive browsing context group swaps can't be done while another context exists in the group, that named lookups are scoped to browsing context groups, and the lookup order in the case of multiple contexts with the same name. Bug: None Change-Id: I515f527fb94a711bdd8eeb6610df2127571dcc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6081814 Reviewed-by: Domenic Denicola <[email protected]> Commit-Queue: Kevin McNee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1394596}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6081814
branch
from
December 11, 2024 00:56
aa5e57b to
0182295
Compare
wpt-pr-bot
approved these changes
Dec 11, 2024
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This was referenced Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests verify the behaviour discussed here:
whatwg/html#10818
While there is some implementation defined behaviour, we can add tests
for the behaviour that's consistent between the major implementations,
namely that proactive browsing context group swaps can't be done while
another context exists in the group, that named lookups are scoped to
browsing context groups, and the lookup order in the case of multiple
contexts with the same name.
Bug: None
Change-Id: I515f527fb94a711bdd8eeb6610df2127571dcc3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6081814
Reviewed-by: Domenic Denicola <[email protected]>
Commit-Queue: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1394596}