Conversation
|
Notifying @Ms2ger, @ayg, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) These tests will be available shortly on w3c-test.org. |
Chrome (unstable channel)Testing web-platform-tests at revision dab6bb8a06664e8a27222105cad67939971ec229 All results2 tests ran/html/browsers/browsing-the-web/unloading-documents/beforeunload-canceling.html
/html/webappapis/scripting/events/event-handler-processing-algorithm.html
|
Firefox (nightly channel)Testing web-platform-tests at revision dab6bb8a06664e8a27222105cad67939971ec229 All results2 tests ran/html/browsers/browsing-the-web/unloading-documents/beforeunload-canceling.html
/html/webappapis/scripting/events/event-handler-processing-algorithm.html
|
| } | ||
| ]; | ||
|
|
||
| for (const testCase of testCases) { |
There was a problem hiding this comment.
I think we're trying to avoid using for const of since it's such a new construct.
There was a problem hiding this comment.
It works fine in all stable shipped browsers, so I've been using it in all my recent tests.
There was a problem hiding this comment.
It's not supported in Servo yet; I thought I saw @annevk say something about it recently, but I can't find evidence of that now.
There was a problem hiding this comment.
Well, I hope Servo catches up to Firefox's JS engine soon.
There was a problem hiding this comment.
FWIW, I don't recall saying anything about it. I'm personally on board with using new ECMAScript features as they tend to simplify writing tests.
There was a problem hiding this comment.
We're stuck on an older version until we get automated Rust to C++ bindings sorted out, which is an ongoing process.
There was a problem hiding this comment.
If they're merged as-is and Servo needs the test coverage, we'll modify them. It would be nice to skip that step though!
There was a problem hiding this comment.
I don't think it's reasonable to expect all browser developers know what the limitations of Servo are. However for people who do know it feels like it isn't really in the spirit of the exercise to intentionally use features that are known to be problematic but have no substantial benefits.
There was a problem hiding this comment.
To be clear, I don't know what Servo does and doesn't support. I wrote some tests as I normally do, using features that I feel have substantial benefits (your personal value judgment notwithstanding), and then was sidetracked by this discussion, where people started telling me things about Servo that I don't really intend to keep around in my mental map of the browser landscape.
|
Spec patch is merged. |
| assert_equals(ev.defaultPrevented, false); | ||
| t.done(); | ||
| }, "beforeunload listener returning non-null doesn't cancel event"); | ||
| // beforeunload is tested in beforeunload-canceling.html |
There was a problem hiding this comment.
This should probably be a clearer reference since it's not in the same directory. LGTM with that.
6 participants
Follows whatwg/html#2353.