Upstream Node.js URL test data #4693
Conversation
|
Notifying @Sebmaster, @domenic, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) These tests will be available shortly on w3c-test.org. w3c-test:do-not-mirror (What's this?) |
|
The second commit added expected origins(need more thorough reviews), currently Node.js is unable to produce these expected origins either. |
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
The URL parsing looks good; the origins should all be the string "null" per https://url.spec.whatwg.org/#origin "Otherwise" + https://html.spec.whatwg.org/multipage/browsers.html#unicode-serialisation-of-an-origin step 1
joyeecheung
force-pushed
the
nodejs-urltestdata
branch
from
f930654 to
81329e4
Compare
|
Ah, forgot these schemes should've resulted int opaque origins. Thanks, I've updated them to |
url-tests-additional.js now is a placeholder since existing test cases have been upstreamed. This is now a temporary place for test cases not upstreamed yet. Refs: web-platform-tests/wpt#4693 PR-URL: #11439 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
url-tests-additional.js now is a placeholder since existing test cases have been upstreamed. This is now a temporary place for test cases not upstreamed yet. Refs: web-platform-tests/wpt#4693 PR-URL: nodejs#11439 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 participants
Refs: nodejs/node#11079
cc @domenic