Core-AAM: add tests for sectionheader and sectionfooter - #45916
Conversation
cookiecrook
left a comment
cookiecrook
left a comment
There was a problem hiding this comment.
This would result in new failures for Interop, so please keep the WebDriver role verifications out. Adding to a roles.tentative.html file is fine, as those don't affect the score.
Even if we agreed on the test additions, there's a process inside the current Interop project together sign off from implementors before making new changes that would affect the score mid-year.
f28d642 to
2aa23d5
Compare
spectranaut
changed the title
|
Ok @cookiecrook -- I moved sectionheader and sectionfooter to a tentative file: #46142 If we need sign off from implementers for WPT tests of new futures added to ARIA, we should note that in the ARIA process documents, I'll ping you for a review of that draft. |
Thanks. FYI there is still an accidental white space diff remaining in roles.html. |
|
Is there a PR to update the header and footer (scoped to main/sectioning content) subtests in html-aam/roles-contextual.html and wai-aria/role/contextual-roles.html? I have the implementation for sectionheader and sectionfooter ready for Chrome, but it's currently failing those subtests. I'm holding off on merging the code because it would negatively impact our Interop score. |
Hi Joceyln, if there is a missing test or failing test, maybe make an issue on ARIA with the details so we can update it? This PR just has manual tests to keep track of the API mappings. |
2aa23d5 to
7c624e6
Compare
cookiecrook
left a comment
cookiecrook
left a comment
There was a problem hiding this comment.
Approving with the updates from the spec PR
rahimabdi
left a comment
rahimabdi
left a comment
There was a problem hiding this comment.
@cookiecrook has kindly provided comments/suggested feedback.
Co-authored-by: James Craig <[email protected]>
|
Thanks @cookiecrook ! Fixed. |
6 participants
Change in ARIA: w3c/aria#1931