Skip to content

HTML{Meter,Progress}Element shouldn't have a .form property#4577

Merged
zcorpan merged 1 commit intomasterfrom
meter-progress-form
Jan 20, 2017
Merged

HTML{Meter,Progress}Element shouldn't have a .form property#4577
zcorpan merged 1 commit intomasterfrom
meter-progress-form

Conversation

@cvrebert
Copy link
Copy Markdown
Contributor

@wpt-pr-bot
Copy link
Copy Markdown
Collaborator

@wpt-stability-bot
Copy link
Copy Markdown

Firefox (nightly channel)

Testing web-platform-tests at revision de78892
Using browser at version BuildID 20170118211214; SourceStamp a5253dce8b67c2248d7b92ef664a6dd6664e7609
Starting 10 test iterations
All results were stable

All results

/html/semantics/forms/form-control-infrastructure/form.html
Subtest Results
OK
label-form.form PASS
input.form PASS
textarea.form PASS
label-in-table-for.form PASS
label-for-control-form.form PASS
select.form PASS
object.form PASS
output.form PASS
label-with-control.form PASS
label-in-table.form PASS
button.form PASS
fieldset.form PASS
label.form PASS
label-for-control-form-in-form.form PASS
label-form-form2.form PASS
label-in-table-with-control.form PASS
label-for.form PASS

@wpt-stability-bot
Copy link
Copy Markdown

Chrome (unstable channel)

Testing web-platform-tests at revision de78892
Using browser at version 55.0.2883.75
Starting 10 test iterations
All results were stable

All results

/html/semantics/forms/form-control-infrastructure/form.html
Subtest Results
OK
label-form.form PASS
input.form PASS
textarea.form PASS
label-in-table-for.form PASS
label-for-control-form.form PASS
select.form PASS
object.form PASS
output.form PASS
label-with-control.form PASS
label-in-table.form PASS
button.form PASS
fieldset.form PASS
label.form PASS
label-for-control-form-in-form.form PASS
label-form-form2.form PASS
label-in-table-with-control.form PASS
label-for.form PASS

@domenic
Copy link
Copy Markdown
Member

domenic commented Jan 20, 2017

It might be good to test that they don't exist, as it's an easy thing to get wrong.

@cvrebert cvrebert changed the title Remove inaccurate tests for HTML{Meter,Progress}Element.form HTML{Meter,Progress}Element shouldn't have a .form property Jan 20, 2017
@cvrebert
Copy link
Copy Markdown
Contributor Author

@zcorpan zcorpan merged commit 1e423cc into master Jan 20, 2017
@zcorpan zcorpan deleted the meter-progress-form branch January 20, 2017 08:16
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 9, 2025
To be able to abort the update, extract the functionality into a
separate method. Otherwise, we don't run the `node.rev_version`
at the end, which according to the comment is probably important.

Not all `style-src` tests pass and I don't fully understand why yet,
but I presume it has to do with some special quirks of stylesheets
that other CSP checks don't have. All `style-src-attr-elem` tests
pass though.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 9, 2025
To be able to abort the update, extract the functionality into a
separate method. Otherwise, we don't run the `node.rev_version`
at the end, which according to the comment is probably important.

Not all `style-src` tests pass and I don't fully understand why yet,
but I presume it has to do with some special quirks of stylesheets
that other CSP checks don't have. All `style-src-attr-elem` tests
pass though.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit that referenced this pull request May 9, 2025
To be able to abort the update, extract the functionality into a
separate method. Otherwise, we don't run the `node.rev_version`
at the end, which according to the comment is probably important.

Not all `style-src` tests pass and I don't fully understand why yet,
but I presume it has to do with some special quirks of stylesheets
that other CSP checks don't have. All `style-src-attr-elem` tests
pass though.

Part of #4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 13, 2025
Also update the `html/dom/reflection-metadata.html` test
to handle the case where `nonce` does not reflect back
to the attribute after an IDL change.

Part of web-platform-tests#4577
Fixes web-platform-tests#43286

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 13, 2025
Also update the `html/dom/reflection-metadata.html` test
to handle the case where `nonce` does not reflect back
to the attribute after an IDL change.

Part of web-platform-tests#4577
Fixes web-platform-tests#43286

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 14, 2025
Also update the `html/dom/reflection-metadata.html` test
to handle the case where `nonce` does not reflect back
to the attribute after an IDL change.

Part of web-platform-tests#4577
Fixes web-platform-tests#43286

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 14, 2025
Also update the `html/dom/reflection-metadata.html` test
to handle the case where `nonce` does not reflect back
to the attribute after an IDL change.

Part of web-platform-tests#4577
Fixes web-platform-tests#43286

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit that referenced this pull request May 14, 2025
Also update the `html/dom/reflection-metadata.html` test
to handle the case where `nonce` does not reflect back
to the attribute after an IDL change.

Part of #4577
Fixes #43286

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 15, 2025
This way, we don't always set the destination to Document
(which is as the spec is written today). Instead, we set
it it in the load_data, depending on which context we
load it from.

Doing so allows us to set the `Destination::IFrame` for
navigations in iframes, enabling all frame-related CSP
checks.

While we currently block iframes when `frame-src` or
`child-src` is set, their respective tests don't pass
yet. That's because we don't yet handle the cases
where we fire the correct `load` event.

Also update one WPT test to correctly fail, rather than
erroring. That's because it was using the wrong JS
test variable.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 16, 2025
This way, we don't always set the destination to Document
(which is as the spec is written today). Instead, we set
it it in the load_data, depending on which context we
load it from.

Doing so allows us to set the `Destination::IFrame` for
navigations in iframes, enabling all frame-related CSP
checks.

While we currently block iframes when `frame-src` or
`child-src` is set, their respective tests don't pass
yet. That's because we don't yet handle the cases
where we fire the correct `load` event.

Also update one WPT test to correctly fail, rather than
erroring. That's because it was using the wrong JS
test variable.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 16, 2025
This way, we don't always set the destination to Document
(which is as the spec is written today). Instead, we set
it it in the load_data, depending on which context we
load it from.

Doing so allows us to set the `Destination::IFrame` for
navigations in iframes, enabling all frame-related CSP
checks.

While we currently block iframes when `frame-src` or
`child-src` is set, their respective tests don't pass
yet. That's because we don't yet handle the cases
where we fire the correct `load` event.

Also update one WPT test to correctly fail, rather than
erroring. That's because it was using the wrong JS
test variable.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 16, 2025
This way, we don't always set the destination to Document
(which is as the spec is written today). Instead, we set
it it in the load_data, depending on which context we
load it from.

Doing so allows us to set the `Destination::IFrame` for
navigations in iframes, enabling all frame-related CSP
checks.

While we currently block iframes when `frame-src` or
`child-src` is set, their respective tests don't pass
yet. That's because we don't yet handle the cases
where we fire the correct `load` event.

Also update one WPT test to correctly fail, rather than
erroring. That's because it was using the wrong JS
test variable.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit that referenced this pull request May 17, 2025
This way, we don't always set the destination to Document
(which is as the spec is written today). Instead, we set
it it in the load_data, depending on which context we
load it from.

Doing so allows us to set the `Destination::IFrame` for
navigations in iframes, enabling all frame-related CSP
checks.

While we currently block iframes when `frame-src` or
`child-src` is set, their respective tests don't pass
yet. That's because we don't yet handle the cases
where we fire the correct `load` event.

Also update one WPT test to correctly fail, rather than
erroring. That's because it was using the wrong JS
test variable.

Part of #4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 18, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 18, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 18, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 18, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 18, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 20, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 20, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 20, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 27, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request May 27, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of web-platform-tests#4577
Part of web-platform-tests#35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit that referenced this pull request May 29, 2025
These changes allow a minimal set of checks for font-src
CSP checks to pass.

Part of #4577
Part of #35035

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jun 14, 2025
Cloned nodes were re-parsing already-parsed style
attributes. As such, they were also checking CSP, which
shouldn't happen as the original node already was checked
for it.

The existing WPT test now mostly passes. It had two cases
which were passing in no browsers. Therefore, update it
to reflect browser behavior (which Servo also now does).

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jun 14, 2025
Cloned nodes were re-parsing already-parsed style
attributes. As such, they were also checking CSP, which
shouldn't happen as the original node already was checked
for it.

The existing WPT test now mostly passes. It had two cases
which were passing in no browsers. Therefore, update it
to reflect browser behavior (which Servo also now does).

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jun 15, 2025
Cloned nodes were re-parsing already-parsed style
attributes. As such, they were also checking CSP, which
shouldn't happen as the original node already was checked
for it.

The existing WPT test now mostly passes. It had two cases
which were passing in no browsers.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jun 28, 2025
Cloned nodes were re-parsing already-parsed style
attributes. As such, they were also checking CSP, which
shouldn't happen as the original node already was checked
for it.

The existing WPT test now mostly passes. It had two cases
which were passing in no browsers.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit that referenced this pull request Jun 28, 2025
Cloned nodes were re-parsing already-parsed style
attributes. As such, they were also checking CSP, which
shouldn't happen as the original node already was checked
for it.

The existing WPT test now mostly passes. It had two cases
which were passing in no browsers.

Part of #4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jul 12, 2025
This was a bit confusing at first, but the report-only only
had an effect if it was used in conjunction with the regular
CSP header. This is incorrect, as the report-only header
can be present on its own.

Additionally, there was double-logic for parsing the CSP list
values, since we can only concatenate CSP lists if we have
an initial value, which requires a concrete policy value.

Therefore, abstract that way by looping over both headers and
handling the case where initially it is `None` and, if the
CSP header is not present, still `None` when we parse
the `report-only` header.

Additionally, update two WPT tests. One was expecting the image
to load, yet was showing the fail image. The other one is
currently still failing for Servo, but crashes the test runner.
Now it no longer times out, but has the wrong value for
number of reports.

Part of web-platform-tests#4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit that referenced this pull request Jul 12, 2025
This was a bit confusing at first, but the report-only only
had an effect if it was used in conjunction with the regular
CSP header. This is incorrect, as the report-only header
can be present on its own.

Additionally, there was double-logic for parsing the CSP list
values, since we can only concatenate CSP lists if we have
an initial value, which requires a concrete policy value.

Therefore, abstract that way by looping over both headers and
handling the case where initially it is `None` and, if the
CSP header is not present, still `None` when we parse
the `report-only` header.

Additionally, update two WPT tests. One was expecting the image
to load, yet was showing the fail image. The other one is
currently still failing for Servo, but crashes the test runner.
Now it no longer times out, but has the wrong value for
number of reports.

Part of #4577

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jul 18, 2025
Any CSP violations happening when loading a worker should be reported
on the global of the document that creates the worker. Since workers
run in different threads, we can't pass in this parent global into
the worker global scope. Instead, we need to send a message to the
parent event loop to report it on the correct global.

Part of web-platform-tests#4577
Fixes web-platform-tests#37027

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jul 18, 2025
Any CSP violations happening when loading a worker should be reported
on the global of the document that creates the worker. Since workers
run in different threads, we can't pass in this parent global into
the worker global scope. Instead, we need to send a message to the
parent event loop to report it on the correct global.

Part of web-platform-tests#4577
Fixes web-platform-tests#37027

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jul 19, 2025
Any CSP violations happening when loading a worker should be reported
on the global of the document that creates the worker. Since workers
run in different threads, we can't pass in this parent global into
the worker global scope. Instead, we need to send a message to the
parent event loop to report it on the correct global.

Part of web-platform-tests#4577
Fixes web-platform-tests#37027

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit to servo/wpt that referenced this pull request Jul 19, 2025
Any CSP violations happening when loading a worker should be reported
on the global of the document that creates the worker. Since workers
run in different threads, we can't pass in this parent global into
the worker global scope. Instead, we need to send a message to the
parent event loop to report it on the correct global.

Part of web-platform-tests#4577
Fixes web-platform-tests#37027

Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync pushed a commit that referenced this pull request Jul 20, 2025
Any CSP violations happening when loading a worker should be reported
on the global of the document that creates the worker. Since workers
run in different threads, we can't pass in this parent global into
the worker global scope. Instead, we need to send a message to the
parent event loop to report it on the correct global.

Part of #4577
Fixes #37027

Signed-off-by: Tim van der Lippe <[email protected]>
foolip pushed a commit that referenced this pull request Aug 13, 2025
Any CSP violations happening when loading a worker should be reported
on the global of the document that creates the worker. Since workers
run in different threads, we can't pass in this parent global into
the worker global scope. Instead, we need to send a message to the
parent event loop to report it on the correct global.

Part of #4577
Fixes #37027

Signed-off-by: Tim van der Lippe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants