HTML{Meter,Progress}Element shouldn't have a .form property#4577
Merged
HTML{Meter,Progress}Element shouldn't have a .form property#4577
Conversation
Per the specification, these interfaces have no `.form` property: * https://html.spec.whatwg.org/multipage/#htmlmeterelement * https://html.spec.whatwg.org/multipage/#htmlprogresselement
Collaborator
|
Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
Firefox (nightly channel)Testing web-platform-tests at revision de78892 All results/html/semantics/forms/form-control-infrastructure/form.html
|
Chrome (unstable channel)Testing web-platform-tests at revision de78892 All results/html/semantics/forms/form-control-infrastructure/form.html
|
Member
|
It might be good to test that they don't exist, as it's an easy thing to get wrong. |
Contributor
Author
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 9, 2025
To be able to abort the update, extract the functionality into a separate method. Otherwise, we don't run the `node.rev_version` at the end, which according to the comment is probably important. Not all `style-src` tests pass and I don't fully understand why yet, but I presume it has to do with some special quirks of stylesheets that other CSP checks don't have. All `style-src-attr-elem` tests pass though. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 9, 2025
To be able to abort the update, extract the functionality into a separate method. Otherwise, we don't run the `node.rev_version` at the end, which according to the comment is probably important. Not all `style-src` tests pass and I don't fully understand why yet, but I presume it has to do with some special quirks of stylesheets that other CSP checks don't have. All `style-src-attr-elem` tests pass though. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
May 9, 2025
To be able to abort the update, extract the functionality into a separate method. Otherwise, we don't run the `node.rev_version` at the end, which according to the comment is probably important. Not all `style-src` tests pass and I don't fully understand why yet, but I presume it has to do with some special quirks of stylesheets that other CSP checks don't have. All `style-src-attr-elem` tests pass though. Part of #4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 13, 2025
Also update the `html/dom/reflection-metadata.html` test to handle the case where `nonce` does not reflect back to the attribute after an IDL change. Part of web-platform-tests#4577 Fixes web-platform-tests#43286 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 13, 2025
Also update the `html/dom/reflection-metadata.html` test to handle the case where `nonce` does not reflect back to the attribute after an IDL change. Part of web-platform-tests#4577 Fixes web-platform-tests#43286 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 14, 2025
Also update the `html/dom/reflection-metadata.html` test to handle the case where `nonce` does not reflect back to the attribute after an IDL change. Part of web-platform-tests#4577 Fixes web-platform-tests#43286 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 14, 2025
Also update the `html/dom/reflection-metadata.html` test to handle the case where `nonce` does not reflect back to the attribute after an IDL change. Part of web-platform-tests#4577 Fixes web-platform-tests#43286 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
May 14, 2025
Also update the `html/dom/reflection-metadata.html` test to handle the case where `nonce` does not reflect back to the attribute after an IDL change. Part of #4577 Fixes #43286 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 15, 2025
This way, we don't always set the destination to Document (which is as the spec is written today). Instead, we set it it in the load_data, depending on which context we load it from. Doing so allows us to set the `Destination::IFrame` for navigations in iframes, enabling all frame-related CSP checks. While we currently block iframes when `frame-src` or `child-src` is set, their respective tests don't pass yet. That's because we don't yet handle the cases where we fire the correct `load` event. Also update one WPT test to correctly fail, rather than erroring. That's because it was using the wrong JS test variable. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 16, 2025
This way, we don't always set the destination to Document (which is as the spec is written today). Instead, we set it it in the load_data, depending on which context we load it from. Doing so allows us to set the `Destination::IFrame` for navigations in iframes, enabling all frame-related CSP checks. While we currently block iframes when `frame-src` or `child-src` is set, their respective tests don't pass yet. That's because we don't yet handle the cases where we fire the correct `load` event. Also update one WPT test to correctly fail, rather than erroring. That's because it was using the wrong JS test variable. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 16, 2025
This way, we don't always set the destination to Document (which is as the spec is written today). Instead, we set it it in the load_data, depending on which context we load it from. Doing so allows us to set the `Destination::IFrame` for navigations in iframes, enabling all frame-related CSP checks. While we currently block iframes when `frame-src` or `child-src` is set, their respective tests don't pass yet. That's because we don't yet handle the cases where we fire the correct `load` event. Also update one WPT test to correctly fail, rather than erroring. That's because it was using the wrong JS test variable. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 16, 2025
This way, we don't always set the destination to Document (which is as the spec is written today). Instead, we set it it in the load_data, depending on which context we load it from. Doing so allows us to set the `Destination::IFrame` for navigations in iframes, enabling all frame-related CSP checks. While we currently block iframes when `frame-src` or `child-src` is set, their respective tests don't pass yet. That's because we don't yet handle the cases where we fire the correct `load` event. Also update one WPT test to correctly fail, rather than erroring. That's because it was using the wrong JS test variable. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
May 17, 2025
This way, we don't always set the destination to Document (which is as the spec is written today). Instead, we set it it in the load_data, depending on which context we load it from. Doing so allows us to set the `Destination::IFrame` for navigations in iframes, enabling all frame-related CSP checks. While we currently block iframes when `frame-src` or `child-src` is set, their respective tests don't pass yet. That's because we don't yet handle the cases where we fire the correct `load` event. Also update one WPT test to correctly fail, rather than erroring. That's because it was using the wrong JS test variable. Part of #4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 18, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 18, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 18, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 18, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 18, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 20, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 20, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 20, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 27, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
May 27, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of web-platform-tests#4577 Part of web-platform-tests#35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
May 29, 2025
These changes allow a minimal set of checks for font-src CSP checks to pass. Part of #4577 Part of #35035 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jun 14, 2025
Cloned nodes were re-parsing already-parsed style attributes. As such, they were also checking CSP, which shouldn't happen as the original node already was checked for it. The existing WPT test now mostly passes. It had two cases which were passing in no browsers. Therefore, update it to reflect browser behavior (which Servo also now does). Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jun 14, 2025
Cloned nodes were re-parsing already-parsed style attributes. As such, they were also checking CSP, which shouldn't happen as the original node already was checked for it. The existing WPT test now mostly passes. It had two cases which were passing in no browsers. Therefore, update it to reflect browser behavior (which Servo also now does). Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jun 15, 2025
Cloned nodes were re-parsing already-parsed style attributes. As such, they were also checking CSP, which shouldn't happen as the original node already was checked for it. The existing WPT test now mostly passes. It had two cases which were passing in no browsers. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jun 28, 2025
Cloned nodes were re-parsing already-parsed style attributes. As such, they were also checking CSP, which shouldn't happen as the original node already was checked for it. The existing WPT test now mostly passes. It had two cases which were passing in no browsers. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
Jun 28, 2025
Cloned nodes were re-parsing already-parsed style attributes. As such, they were also checking CSP, which shouldn't happen as the original node already was checked for it. The existing WPT test now mostly passes. It had two cases which were passing in no browsers. Part of #4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jul 12, 2025
This was a bit confusing at first, but the report-only only had an effect if it was used in conjunction with the regular CSP header. This is incorrect, as the report-only header can be present on its own. Additionally, there was double-logic for parsing the CSP list values, since we can only concatenate CSP lists if we have an initial value, which requires a concrete policy value. Therefore, abstract that way by looping over both headers and handling the case where initially it is `None` and, if the CSP header is not present, still `None` when we parse the `report-only` header. Additionally, update two WPT tests. One was expecting the image to load, yet was showing the fail image. The other one is currently still failing for Servo, but crashes the test runner. Now it no longer times out, but has the wrong value for number of reports. Part of web-platform-tests#4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
Jul 12, 2025
This was a bit confusing at first, but the report-only only had an effect if it was used in conjunction with the regular CSP header. This is incorrect, as the report-only header can be present on its own. Additionally, there was double-logic for parsing the CSP list values, since we can only concatenate CSP lists if we have an initial value, which requires a concrete policy value. Therefore, abstract that way by looping over both headers and handling the case where initially it is `None` and, if the CSP header is not present, still `None` when we parse the `report-only` header. Additionally, update two WPT tests. One was expecting the image to load, yet was showing the fail image. The other one is currently still failing for Servo, but crashes the test runner. Now it no longer times out, but has the wrong value for number of reports. Part of #4577 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jul 18, 2025
Any CSP violations happening when loading a worker should be reported on the global of the document that creates the worker. Since workers run in different threads, we can't pass in this parent global into the worker global scope. Instead, we need to send a message to the parent event loop to report it on the correct global. Part of web-platform-tests#4577 Fixes web-platform-tests#37027 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jul 18, 2025
Any CSP violations happening when loading a worker should be reported on the global of the document that creates the worker. Since workers run in different threads, we can't pass in this parent global into the worker global scope. Instead, we need to send a message to the parent event loop to report it on the correct global. Part of web-platform-tests#4577 Fixes web-platform-tests#37027 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jul 19, 2025
Any CSP violations happening when loading a worker should be reported on the global of the document that creates the worker. Since workers run in different threads, we can't pass in this parent global into the worker global scope. Instead, we need to send a message to the parent event loop to report it on the correct global. Part of web-platform-tests#4577 Fixes web-platform-tests#37027 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jul 19, 2025
Any CSP violations happening when loading a worker should be reported on the global of the document that creates the worker. Since workers run in different threads, we can't pass in this parent global into the worker global scope. Instead, we need to send a message to the parent event loop to report it on the correct global. Part of web-platform-tests#4577 Fixes web-platform-tests#37027 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
Jul 20, 2025
Any CSP violations happening when loading a worker should be reported on the global of the document that creates the worker. Since workers run in different threads, we can't pass in this parent global into the worker global scope. Instead, we need to send a message to the parent event loop to report it on the correct global. Part of #4577 Fixes #37027 Signed-off-by: Tim van der Lippe <[email protected]>
foolip
pushed a commit
that referenced
this pull request
Aug 13, 2025
Any CSP violations happening when loading a worker should be reported on the global of the document that creates the worker. Since workers run in different threads, we can't pass in this parent global into the worker global scope. Instead, we need to send a message to the parent event loop to report it on the correct global. Part of #4577 Fixes #37027 Signed-off-by: Tim van der Lippe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the specification, these interfaces have no
.formproperty: