[webnn] Remove float32 tests with autoPad option#44823
Merged
Honry merged 1 commit intoweb-platform-tests:masterfrom Feb 28, 2024
Merged
[webnn] Remove float32 tests with autoPad option#44823Honry merged 1 commit intoweb-platform-tests:masterfrom
Honry merged 1 commit intoweb-platform-tests:masterfrom
Conversation
conv2d / convTranspose2d / Pooling operations
fdwr
approved these changes
Feb 28, 2024
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
LGTM - WPT simplified. I hope you're not too sad half the tests are gone!
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 8, 2024
This CL removes the MLAutoPad enum and its usages for conv2d, convTranspose2d and pool2d operators according to WebNN spec change [1]. The WPT already removed the test cases for MLAutoPad [2], so there are no changes of WPT and baseline in this CL. [1]: webmachinelearning/webnn#587 [2]: web-platform-tests/wpt#44823 Bug: 40206287,327499424 Change-Id: I5df94d3ecc95a597286bb5633a8c3fa2a563b02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5338716 Reviewed-by: Alex Gough <[email protected]> Commit-Queue: ningxin hu <[email protected]> Reviewed-by: Austin Sullivan <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Cr-Commit-Position: refs/heads/main@{#1269941}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is to align with latest WebNN API Spec change of removing MLAutoPad, link to webmachinelearning/webnn#326.
@fdwr @Honry PTAL, thanks.