webrtc wpt: attach MediaStream to element attached to the DOM#44742
Merged
Conversation
which is required to make some browsers render audio BUG=40115293 Change-Id: I3206ed0b6436ee15cc25a5ce05fc806321693e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318131 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1264569}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5318131
branch
from
ff2d87d to
a88d5fe
Compare
wpt-pr-bot
approved these changes
Feb 23, 2024
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Contributor
|
need to clean up metadata next week similar to web-platform-tests/wpt-metadata#5114 |
servo-wpt-sync
pushed a commit
that referenced
this pull request
May 5, 2026
The state of the document after `range.deleteContents` leads to the delete command to traverse to the root element and then crash. Instead, we should simply stop the loop and continue the algorithm and delete backwards. Fixes #44742 Signed-off-by: Tim van der Lippe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which is required to make some browsers render audio
BUG=40115293
Change-Id: I3206ed0b6436ee15cc25a5ce05fc806321693e0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318131
Commit-Queue: Philipp Hancke <[email protected]>
Reviewed-by: Harald Alvestrand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1264569}