[webnn] Add float32 tests for element-wise unary identity operation#43177
Merged
Honry merged 3 commits intoweb-platform-tests:masterfrom Nov 28, 2023
Merged
[webnn] Add float32 tests for element-wise unary identity operation#43177Honry merged 3 commits intoweb-platform-tests:masterfrom
Honry merged 3 commits intoweb-platform-tests:masterfrom
Conversation
fdwr
approved these changes
Nov 16, 2023
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
Bruce, thanks for implementing identity.
| -2.8501904010772705, | ||
| 3.279616355895996 | ||
| ], | ||
| "type": "float32" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
How about a float16 case?
I will submit another PR for only float16 tests.
And if you agree with my current solution of testing float16 tests on #42420, I will add such float16 tests soon.
BruceDai
changed the title
Contributor
Author
|
Hi @fdwr, I synced with @huningxin, we decided to rename copy tests to previous identity tests, since Chromium WebNN API implementation has already supported identity op, then these WPT identity tests can be ran, please take another look at this update, thanks. |
fdwr
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fdwr @huningxin @Honry PTAL, thanks.