[Gecko Bug 1858362] Style invalidation after call to CSS.registerProperty.#42481
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Oct 13, 2023
Merged
[Gecko Bug 1858362] Style invalidation after call to CSS.registerProperty.#42481moz-wptsync-bot merged 1 commit intomasterfrom
moz-wptsync-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Oct 11, 2023
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Call to CSS.registerProperty may result in rendering changes compared to when variables were interpreted as unregistered custom properties. Ensure we recascade style for the whole document tree. This was already covered by WPTs but add a more direct check for paint and reflow. Differential Revision: https://phabricator.services.mozilla.com/D190656 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1858362 gecko-commit: 1b47cd29b7c39df5f3bf62e090bef658e2d03664 gecko-reviewers: emilio
moz-wptsync-bot
force-pushed
the
gecko/1858362
branch
from
77f1b64 to
871fb59
Compare
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Feb 12, 2026
…ion (web-platform-tests#42481) Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call to CSS.registerProperty may result in rendering changes compared
to when variables were interpreted as unregistered custom properties.
Ensure we recascade style for the whole document tree.
This was already covered by WPTs but add a more direct check for
paint and reflow.
Differential Revision: https://phabricator.services.mozilla.com/D190656
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1858362
gecko-commit: 8dbb04b2762bb8887488b710517a201b2ad09d9d
gecko-reviewers: emilio