[text-autospace][text-spacing-trim] Support text-spacing shorthand#42477
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Oct 12, 2023
Merged
[text-autospace][text-spacing-trim] Support text-spacing shorthand#42477chromium-wpt-export-bot merged 1 commit intomasterfrom
text-spacing shorthand#42477chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Oct 11, 2023
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4927468
branch
4 times, most recently
from
9aefcef to
5b414dc
Compare
This patch supports the `text-spacing` shorthand[1], which is for `text-autospace` and `text-spacing-trim`. The `normal` and `none` preset values are supported, but the `auto` isn't supported because it's not supported in `text-autospace` and `text-spacing-trim` either. [1] https://drafts.csswg.org/css-text-4/#text-spacing-property Bug: 1463890, 1463891 Change-Id: Ic2f7a72502f52c3ab111801daf541850ffcf2998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4927468 Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1208708}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4927468
branch
from
5b414dc to
02edbb8
Compare
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Feb 9, 2026
Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Feb 9, 2026
Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Feb 12, 2026
…ion (web-platform-tests#42481) Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
jdm
pushed a commit
that referenced
this pull request
Mar 4, 2026
Most likely a regression introduced in #42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes #42477 Signed-off-by: Tim van der Lippe <[email protected]>
shubhamg13
pushed a commit
to shubhamg13/wpt
that referenced
this pull request
Mar 6, 2026
Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch supports the
text-spacingshorthand[1], which isfor
text-autospaceandtext-spacing-trim.The
normalandnonepreset values are supported, but theautoisn't supported because it's not supported intext-autospaceandtext-spacing-trimeither.[1] https://drafts.csswg.org/css-text-4/#text-spacing-property
Bug: 1463890, 1463891
Change-Id: Ic2f7a72502f52c3ab111801daf541850ffcf2998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4927468
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1208708}