Hand picking relevant logic into FetchLoaderManager#42208
Open
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Open
Hand picking relevant logic into FetchLoaderManager#42208chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Sep 28, 2023
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
DO NOT SUBMIT Change-Id: I1cf2171641ac3aca72d524ad2028197693503e16
16d5b47 to
9c2c359
Compare
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Feb 9, 2026
Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Feb 9, 2026
Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Feb 12, 2026
…ion (web-platform-tests#42481) Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
jdm
pushed a commit
that referenced
this pull request
Mar 4, 2026
Most likely a regression introduced in #42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes #42477 Signed-off-by: Tim van der Lippe <[email protected]>
shubhamg13
pushed a commit
to shubhamg13/wpt
that referenced
this pull request
Mar 6, 2026
Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT SUBMIT
Change-Id: I1cf2171641ac3aca72d524ad2028197693503e16
Reviewed-on: https://chromium-review.googlesource.com/4899666
WPT-Export-Revision: 9fc0e9303b46b2feb520e07f762796250a451082