[Gecko Bug 1819467] part 3: Adjust WPT svg-skewxy-001.html to move vertex of red shape inwards by 1px.#41082
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Jul 18, 2023
Merged
Conversation
…wards by 1px. The testcase has a green shape covering a red shape, and the vertices are close enough to create an opportunity for a little bit of imperceptibly-red fringe along antialiased diagonal lines. This patch shifts two vertices inwards by 1px to create a pixel of breathing room to avoid this antialiased fringe. Differential Revision: https://phabricator.services.mozilla.com/D183581 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1819467 gecko-commit: e325baff84036a8492e20d47e741af7aab67cd00 gecko-reviewers: jfkthame
wpt-pr-bot
approved these changes
Jul 18, 2023
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Dec 6, 2025
The current logic returns early without decrementing the busy count if there are the swap chain doesn't have a front surface. This happens if the context was created but never used for rendering, as seen in the linked issue. Since the count is always incremented when locking, this causes the count to never reach zero, causing the cleanup logic in `remove_webgl_context` to skip freeing the context and associated resources. Fixes web-platform-tests#41082. Signed-off-by: Mukilan Thiyagarajan <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Dec 6, 2025
The current logic returns early without decrementing the busy count if there are the swap chain doesn't have a front surface. This happens if the context was created but never used for rendering, as seen in the linked issue. Since the count is always incremented when locking, this causes the count to never reach zero, causing the cleanup logic in `remove_webgl_context` to skip freeing the context and associated resources. Fixes web-platform-tests#41082. Signed-off-by: Mukilan Thiyagarajan <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
Dec 6, 2025
The current logic returns early without decrementing the busy count if there are the swap chain doesn't have a front surface. This happens if the context was created but never used for rendering, as seen in the linked issue. Since the count is always incremented when locking, this causes the count to never reach zero, causing the cleanup logic in `remove_webgl_context` to skip freeing the context and associated resources. Fixes #41082. Signed-off-by: Mukilan Thiyagarajan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testcase has a green shape covering a red shape, and the vertices are close
enough to create an opportunity for a little bit of imperceptibly-red fringe
along antialiased diagonal lines. This patch shifts two vertices inwards by 1px
to create a pixel of breathing room to avoid this antialiased fringe.
Differential Revision: https://phabricator.services.mozilla.com/D183581
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1819467
gecko-commit: e325baff84036a8492e20d47e741af7aab67cd00
gecko-reviewers: jfkthame