Set empty string for reflection of IDREF attributes#36253
Merged
Conversation
wpt-pr-bot
approved these changes
Oct 4, 2022
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
3 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3934330
branch
2 times, most recently
from
295567a to
e7856cf
Compare
This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3934330
branch
from
e7856cf to
8f290e2
Compare
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 7, 2022
Using the ID of the element led to surprising results in a number of edge cases. Tests: web-platform-tests/wpt#36253. Fixes #8306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the agreement on the following HTML issue:
whatwg/html#8306
HTML PR is available at:
whatwg/html#8352
It just always set the content attribute to the empty string in
Element::SetElementAttribute() and Element::SetElementArrayAttribute().
The WPT test is updated accordingly to the new behavior.
Bug: 1370977
Test: external/wpt/html/dom/aria-element-reflection.html
Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978
Reviewed-on: https://chromium-review.googlesource.com/3934330
WPT-Export-Revision: 1a2f1dd2f44c88af8f5e233f4316d4ee882905f9