Fix success test cases in service-worker-update.https.window.js#35808
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Sep 8, 2022
Merged
Fix success test cases in service-worker-update.https.window.js#35808chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Sep 7, 2022
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3878345
branch
2 times, most recently
from
466b09b to
99c0af3
Compare
The two failing test cases failed not because of PNA checks, but because the browser sends a Service-Worker header which the server didn't explicitly allowed. Using serviceWorkerSuccess will make a query that would return "Access-Control-Allow-Headers: Service-Worker". See also [1] [1] https://chromium-review.googlesource.com/c/chromium/src/+/3858436 Bug: 1239551 Change-Id: I4b61ffd1cdd85521f7d026d845365e3d1341d130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3878345 Auto-Submit: Jonathan Hao <[email protected]> Commit-Queue: Titouan Rigoudy <[email protected]> Reviewed-by: Titouan Rigoudy <[email protected]> Cr-Commit-Position: refs/heads/main@{#1044453}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3878345
branch
from
99c0af3 to
2cece4f
Compare
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Mar 7, 2025
…ock for all descendants (web-platform-tests#35808) * layout: Fix behavior of `transform-style: preserve-3d` This makes `transform-style: preserve-3d` establish a containing block for all descendants, as specified here: <https://drafts.csswg.org/css-transforms-2/#transform-style-property> Signed-off-by: Daniel Hast <[email protected]> * layout: Check for transformable elements Adds a new `is_transformable` helper method and use this in several other methods, including the methods for whether the fragment establishes a new stacking context or a containing block for all descendants. Signed-off-by: Daniel Hast <[email protected]> * Use generic green square reference for reftest. Signed-off-by: Daniel Hast <[email protected]> * layout: Fix stacking context & containing block checks. Only the computed value of `transform-style` should be used to determine whether the element establishes a stacking context and/or a containing block, not the used value. Signed-off-by: Daniel Hast <[email protected]> * Update clip-no-stacking-context test expectation to pass. Signed-off-by: Daniel Hast <[email protected]> --------- Signed-off-by: Daniel Hast <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Mar 10, 2025
…ock for all descendants (web-platform-tests#35808) * layout: Fix behavior of `transform-style: preserve-3d` This makes `transform-style: preserve-3d` establish a containing block for all descendants, as specified here: <https://drafts.csswg.org/css-transforms-2/#transform-style-property> Signed-off-by: Daniel Hast <[email protected]> * layout: Check for transformable elements Adds a new `is_transformable` helper method and use this in several other methods, including the methods for whether the fragment establishes a new stacking context or a containing block for all descendants. Signed-off-by: Daniel Hast <[email protected]> * Use generic green square reference for reftest. Signed-off-by: Daniel Hast <[email protected]> * layout: Fix stacking context & containing block checks. Only the computed value of `transform-style` should be used to determine whether the element establishes a stacking context and/or a containing block, not the used value. Signed-off-by: Daniel Hast <[email protected]> * Update clip-no-stacking-context test expectation to pass. Signed-off-by: Daniel Hast <[email protected]> --------- Signed-off-by: Daniel Hast <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Mar 10, 2025
…ock for all descendants (web-platform-tests#35808) * layout: Fix behavior of `transform-style: preserve-3d` This makes `transform-style: preserve-3d` establish a containing block for all descendants, as specified here: <https://drafts.csswg.org/css-transforms-2/#transform-style-property> Signed-off-by: Daniel Hast <[email protected]> * layout: Check for transformable elements Adds a new `is_transformable` helper method and use this in several other methods, including the methods for whether the fragment establishes a new stacking context or a containing block for all descendants. Signed-off-by: Daniel Hast <[email protected]> * Use generic green square reference for reftest. Signed-off-by: Daniel Hast <[email protected]> * layout: Fix stacking context & containing block checks. Only the computed value of `transform-style` should be used to determine whether the element establishes a stacking context and/or a containing block, not the used value. Signed-off-by: Daniel Hast <[email protected]> * Update clip-no-stacking-context test expectation to pass. Signed-off-by: Daniel Hast <[email protected]> --------- Signed-off-by: Daniel Hast <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two failing test cases failed not because of PNA checks, but because
the browser sends a Service-Worker header which the server didn't explicitly
allowed. Using serviceWorkerSuccess will make a query that would return
"Access-Control-Allow-Headers: Service-Worker". See also [1]
[1] https://chromium-review.googlesource.com/c/chromium/src/+/3858436
Bug: 1239551
Change-Id: I4b61ffd1cdd85521f7d026d845365e3d1341d130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3878345
Auto-Submit: Jonathan Hao <[email protected]>
Commit-Queue: Titouan Rigoudy <[email protected]>
Reviewed-by: Titouan Rigoudy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1044453}