Conversation
domfarolino
reviewed
Jun 7, 2022
| const m = new URL('module1.js', location.href).toString(); | ||
| const observer = new PerformanceObserver(l => { | ||
| const entries = l.getEntriesByName(m); | ||
| if (entries.length === 1) { |
Member
There was a problem hiding this comment.
What if entries.length is more than 1, is that possible? And just for my knowledge here, it will always at least be one, is that right?
Contributor
Author
There was a problem hiding this comment.
It can theoretically be 2 if the module was preloaded, and importing it would not detect the preload and would re-fetch the module.
Member
There was a problem hiding this comment.
But at this point we haven't even imported it. So how could it ever be 2 at this point?
3 tasks
domfarolino
approved these changes
Jun 7, 2022
| const m = new URL('module1.js', location.href).toString(); | ||
| const observer = new PerformanceObserver(l => { | ||
| const entries = l.getEntriesByName(m); | ||
| if (entries.length === 1) { |
Member
There was a problem hiding this comment.
But at this point we haven't even imported it. So how could it ever be 2 at this point?
Hyran15
reviewed
Jun 11, 2022
Hyran15
left a comment
Hyran15
left a comment
There was a problem hiding this comment.
preload/link-header-modulepreload.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.