[URL] More tests of non-forbidden host code points#32539
Merged
domenic merged 1 commit intoweb-platform-tests:masterfrom Jan 25, 2022
Merged
[URL] More tests of non-forbidden host code points#32539domenic merged 1 commit intoweb-platform-tests:masterfrom
domenic merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
requested review from
GPHemsley,
TimothyGu,
annevk,
domenic and
mikewest
3 tasks
domenic
approved these changes
Jan 25, 2022
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Super-helpful, thank you for doing this!
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same tests added in #32524 but with expected values that match the current spec.
These all pass in jsdom, but I expect every browser to fail them. Hence the desire to change the spec.
The organisation is a bit weird (these are listed under the "forbidden" section even though the URLs are supposed to parse), because the idea is that they will be imminently forbidden, and it's easier to review if the tests aren't jumping around too much in the file.
CC @domenic