Skip to content

Add a test for the textContent setter.#321

Merged
zcorpan merged 2 commits intoweb-platform-tests:masterfrom
Ms2ger:textcontent-setter
Sep 26, 2013
Merged

Add a test for the textContent setter.#321
zcorpan merged 2 commits intoweb-platform-tests:masterfrom
Ms2ger:textcontent-setter

Conversation

@Ms2ger
Copy link
Copy Markdown
Contributor

@Ms2ger Ms2ger commented Sep 8, 2013

No description provided.

@hoppipolla-critic-bot
Copy link
Copy Markdown

Critic review: https://critic.hoppipolla.co.uk/r/303

This is an external review system which you may optionally use for the code review of your pull request.

zcorpan added a commit that referenced this pull request Sep 26, 2013
Add a test for the textContent setter.
@zcorpan zcorpan merged commit 931de27 into web-platform-tests:master Sep 26, 2013
jeffcarp pushed a commit that referenced this pull request Mar 23, 2017
… (patchset #5 id:80001 of https://codereview.chromium.org/2723433002/ )

Reason for revert:
Temporarily reverting this CL because it causes a perf regression. See http://crbug.com/703605.

Will reland once we understand why the regression occurred.

Original issue's description:
> Remove |remote| and |readonly| members of MediaStreamTrack.
>
> Spec reference:
> http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1
>
> removal was in the February 22, 2016'.
> [#321] Remove track attributes "remote" and "readonly" :
> w3c/mediacapture-main#321
>
> Intent to Deprecate and Remove :
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI
>
> BUG=598704
>
> Review-Url: https://codereview.chromium.org/2723433002
> Cr-Commit-Position: refs/heads/master@{#456639}
> Committed: https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f0836115fe672

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=598704

Review-Url: https://codereview.chromium.org/2767963002
Cr-Commit-Position: refs/heads/master@{#459096}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants