Skip to content

Use SwiftShader for Chrome and unpin the version used on Taskcluster#29095

Merged
foolip merged 2 commits intomasterfrom
foolip/chrome-swiftshader
Jun 3, 2021
Merged

Use SwiftShader for Chrome and unpin the version used on Taskcluster#29095
foolip merged 2 commits intomasterfrom
foolip/chrome-swiftshader

Conversation

@foolip
Copy link
Copy Markdown
Member

@foolip foolip commented May 24, 2021 •
edited
Loading

With --use-gl=angle --use-angle=swiftshader Chrome doesn't crash on startup,
allowing us to unpin the version used.

The original problem hasn't been resolved, but it's tracked by a Chromium bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=1208904

Fixes #28209.

@wpt-pr-bot wpt-pr-bot requested a review from jgraham May 24, 2021 22:03
@foolip foolip requested a review from past May 24, 2021 22:03
@foolip
Copy link
Copy Markdown
Member Author

foolip commented May 24, 2021

Unpinning tried in 26c315e, looks promising.

@foolip foolip force-pushed the foolip/chrome-swiftshader branch from 05f3d46 to 0a813df Compare May 25, 2021 07:28
@foolip
Copy link
Copy Markdown
Member Author

foolip commented May 25, 2021

I've rebased to trigger some more full runs, which should be compared against https://wpt.fyi/results/?run_id=5642481121099776.

https://community-tc.services.mozilla.com/tasks/groups/ZUFrBGhzSByuXXSrRwCcQQ is for 0a813df, just changing the command line args to --use-gl=angle --use-angle=swiftshader.

https://community-tc.services.mozilla.com/tasks/groups/DQY__Z5hQH6NbjWptRORhQ is for cd02f2b, additionally unpinning the Chrome version.

@foolip
Copy link
Copy Markdown
Member Author

foolip commented May 25, 2021

Sigh, test_run_failing_test and test_run_verify_unstable are also failing, because they start Chrome dev without these arguments...

@wpt-pr-bot wpt-pr-bot added the wpt label May 25, 2021
@foolip foolip changed the title [Taskcluster] use --use-gl=angle --use-angle=swiftshader for Chrome Use SwiftShader for Chrome and unpin the version used on Taskcluster May 25, 2021
@foolip
Copy link
Copy Markdown
Member Author

foolip commented May 25, 2021

@jgraham this fix is a bit unsightly, do you think it's acceptable?

@jgraham
Copy link
Copy Markdown
Contributor

jgraham commented May 25, 2021

I wonder if we should make --chrome-swiftshader an argument to wptrunner a bit like --enable-fission for Gecko, so that we can at least have a single place where we add the binary args rather than requiring every callsite to add them (would be even better if we could make it detect if that's the required configuration ofc).

past
past approved these changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@past past left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I do see the merit of jgraham's suggestion.

@wpt-pr-bot wpt-pr-bot added the wptrunner The automated test runner, commonly called through ./wpt run label Jun 2, 2021
@foolip
Introduce an --enable-swiftshader argument for Chrome
f1f6fa6 
This should allow unpinning Chrome to the latest version, but it's first
done while keeping the version pinned to vet the differences.

Part of #28209.
@foolip foolip force-pushed the foolip/chrome-swiftshader branch from 0652093 to a086a0e Compare June 2, 2021 14:57
@foolip
Revert "[Taskcluster] pin Chrome Dev to 91.0.4472.19"
b02b092 
This reverts #28661.

This requires updating infrastructure/server/context.any.js
expectations.
@foolip foolip force-pushed the foolip/chrome-swiftshader branch from a086a0e to b02b092 Compare June 2, 2021 15:55
@foolip
Copy link
Copy Markdown
Member Author

foolip commented Jun 2, 2021

This seems to have worked. @jgraham would you care to review the new --enable-swiftshader argument?

jgraham
jgraham approved these changes Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jgraham jgraham left a comment •
edited by foolip
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol at Chrome arguments using servo_group for so long.

Right? I guess that just caused the Servo option to not actually work?

@foolip foolip merged commit 8ebb14d into master Jun 3, 2021
@foolip foolip deleted the foolip/chrome-swiftshader branch June 3, 2021 11:00
@foolip
Copy link
Copy Markdown
Member Author

foolip commented Jun 3, 2021

It worked! https://wpt.fyi/results/?diff&filter=ADC&run_id=5733201030938624&run_id=5132966231539712

@foolip foolip mentioned this pull request Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@past past past approved these changes

@jgraham jgraham jgraham approved these changes

Assignees

@jgraham jgraham

Labels

ci infra wpt wptrunner The automated test runner, commonly called through ./wpt run

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chrome crashing on startup on TaskCluster

4 participants

@foolip @jgraham @past @wpt-pr-bot