url: expect hostname setter no-op if a port is given#29021
Merged
TimothyGu merged 1 commit intoweb-platform-tests:masterfrom May 19, 2021
Merged
url: expect hostname setter no-op if a port is given#29021TimothyGu merged 1 commit intoweb-platform-tests:masterfrom
TimothyGu merged 1 commit intoweb-platform-tests:masterfrom
Conversation
This was referenced May 17, 2021
domenic
approved these changes
May 17, 2021
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM, assuming jsdom/whatwg-url passes these tests (and doesn't fail any existing ones) after jsdom/whatwg-url#183 is applied.
Member
Author
|
That's correct, yes |
annevk
pushed a commit
to whatwg/url
that referenced
this pull request
May 19, 2021
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
May 21, 2021
This brings in web-platform-tests/wpt#29021 and web-platform-tests/wpt#29048 while the WPT importer is stuck. No-Export: true Bug: 819342 Change-Id: I76d2d783f700d3af1cfa9c26b36dd372826baf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2909500 Commit-Queue: Timothy Gu <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: Timothy Gu <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/master@{#885282}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns with whatwg/url#604