Skip to content

Streams: add test for canceling both tee'd branches in sequence with delay#28266

Merged
domenic merged 2 commits into
web-platform-tests:masterfrom
MattiasBuelens:rs-tee-cancel-both-with-delay
Mar 29, 2021
Merged

Streams: add test for canceling both tee'd branches in sequence with delay#28266
domenic merged 2 commits into
web-platform-tests:masterfrom
MattiasBuelens:rs-tee-cancel-both-with-delay

Conversation

@MattiasBuelens

Copy link
Copy Markdown
Contributor

Accompanies whatwg/streams#1118.

@MattiasBuelens MattiasBuelens changed the title Streams: test whether canceling both branches in sequence with delay works Streams: add test for canceling both tee'd branches in sequence with delay Mar 27, 2021
Comment thread streams/readable-streams/tee.any.js

@ricea ricea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@domenic
domenic merged commit 1bdb43f into web-platform-tests:master Mar 29, 2021
@MattiasBuelens
MattiasBuelens deleted the rs-tee-cancel-both-with-delay branch March 30, 2021 12:48
domenic pushed a commit to whatwg/streams that referenced this pull request Mar 31, 2021
Browsers were not handling this case correctly (i.e. ignoring the second resolve), as can be seen from web-platform-tests/wpt#28266.
yutakahirano pushed a commit to yutakahirano/streams that referenced this pull request Jun 3, 2021
Browsers were not handling this case correctly (i.e. ignoring the second resolve), as can be seen from web-platform-tests/wpt#28266.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants