Streams: add missing asserts in tee test#28153
Merged
domenic merged 3 commits intoMar 20, 2021
Merged
Conversation
wpt-pr-bot
requested review from
domenic,
ricea,
wanderview,
youennf and
yutakahirano
March 19, 2021 17:28
3 tasks
MattiasBuelens
commented
Mar 19, 2021
domenic
approved these changes
Mar 19, 2021
domenic
requested changes
Mar 19, 2021
domenic
approved these changes
Mar 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In "ReadableStream teeing: failing to cancel the original stream should cause cancel() to reject on branches", we error the stream and then cancel both branches. However, we don't check that those
cancel()promises are actually rejected with the stream's error.This PR adds those missing asserts. This also ensures that implementations don't accidentally reject these promises with an unexpected reason.
Accompanies whatwg/streams#1112.