Add test for proposed AbortSignal.abort()#28003
Merged
annevk merged 1 commit intoweb-platform-tests:masterfrom Mar 12, 2021
Merged
Add test for proposed AbortSignal.abort()#28003annevk merged 1 commit intoweb-platform-tests:masterfrom
annevk merged 1 commit intoweb-platform-tests:masterfrom
Conversation
Proposed new API addition. Refs: whatwg/dom#960
3 tasks
annevk
approved these changes
Mar 11, 2021
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Maybe we should also do an instanceof assert? Hard to think of other angles to test though, it's pretty simple.
annevk
pushed a commit
to whatwg/dom
that referenced
this pull request
Mar 12, 2021
Returns an aborted AbortSignal. Tests: web-platform-tests/wpt#28003. Fixes #959.
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Mar 22, 2021
https://bugs.webkit.org/show_bug.cgi?id=223071 <rdar://problem/75575483> Reviewed by Darin Adler. LayoutTests/imported/w3c: Resync WPT test from upstream a8cbe9c to gain test coverage. * web-platform-tests/dom/abort/event.any-expected.txt: * web-platform-tests/dom/abort/event.any.js: * web-platform-tests/dom/abort/event.any.worker-expected.txt: Source/WebCore: Implement AbortSignal.abort() which creates and returns an already aborted AbortSignal: - whatwg/dom#960 - web-platform-tests/wpt#28003 No new tests, covered by updated test. * dom/AbortSignal.cpp: (WebCore::AbortSignal::createAborted): (WebCore::AbortSignal::AbortSignal): * dom/AbortSignal.h: * dom/AbortSignal.idl: Canonical link: https://commits.webkit.org/235582@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Cwiiis
pushed a commit
to Cwiiis/webkit-deprecated
that referenced
this pull request
Mar 24, 2021
https://bugs.webkit.org/show_bug.cgi?id=223071 <rdar://problem/75575483> Reviewed by Darin Adler. LayoutTests/imported/w3c: Resync WPT test from upstream a8cbe9c712ad032d36 to gain test coverage. * web-platform-tests/dom/abort/event.any-expected.txt: * web-platform-tests/dom/abort/event.any.js: * web-platform-tests/dom/abort/event.any.worker-expected.txt: Source/WebCore: Implement AbortSignal.abort() which creates and returns an already aborted AbortSignal: - whatwg/dom#960 - web-platform-tests/wpt#28003 No new tests, covered by updated test. * dom/AbortSignal.cpp: (WebCore::AbortSignal::createAborted): (WebCore::AbortSignal::AbortSignal): * dom/AbortSignal.h: * dom/AbortSignal.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@274773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed new API addition.
Refs: whatwg/dom#960