Skip to content

Update update_html5lib_tests.py to Python 3#27798

Merged
zcorpan merged 2 commits intomasterfrom
bocoup/update_html5lib_tests_python3
Feb 26, 2021
Merged

Update update_html5lib_tests.py to Python 3#27798
zcorpan merged 2 commits intomasterfrom
bocoup/update_html5lib_tests_python3

Conversation

@zcorpan
Copy link
Copy Markdown
Member

@zcorpan zcorpan commented Feb 26, 2021

No description provided.

@foolip
Copy link
Copy Markdown
Member

foolip commented Feb 26, 2021

Is this script exercised in CI, or does one have to run it locally to check that it still works?

@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Feb 26, 2021

It is run in CI: the update-built check runs update-build-tests.sh which runs html/tools/build.sh which is modified in this PR. I noticed it because it failed in CI when running as Python2.

@foolip
Copy link
Copy Markdown
Member

foolip commented Feb 26, 2021

OK, in that case it's pretty easy to have confidence in this, thanks Simon!

@zcorpan zcorpan merged commit b0fb660 into master Feb 26, 2021
@zcorpan zcorpan deleted the bocoup/update_html5lib_tests_python3 branch February 26, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants