Streams: settle reader.[[closedPromise]] before performing close/error steps of read requests#27236
Merged
domenic merged 3 commits intoFeb 8, 2021
Conversation
wpt-pr-bot
requested review from
domenic,
ricea,
wanderview,
youennf and
yutakahirano
January 19, 2021 00:22
3 tasks
domenic
approved these changes
Jan 19, 2021
domenic
left a comment
domenic
left a comment
Member
There was a problem hiding this comment.
LGTM but we shouldn't merge the general.any.js change until the spec change is merged.
ricea
reviewed
Feb 4, 2021
… reader releases its lock
Member
|
Oh, shoot, I forgot that @ricea had substantive comments on the last round. I should let him have another look at this to give his LGTM before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accompanies whatwg/streams#1102