[Taskcluster] Run Py3 infrastructure/ tests on Firefox as well as Chrome#27104
Closed
stephenmcgruer wants to merge 1 commit intomasterfrom
Closed
[Taskcluster] Run Py3 infrastructure/ tests on Firefox as well as Chrome#27104stephenmcgruer wants to merge 1 commit intomasterfrom
stephenmcgruer wants to merge 1 commit intomasterfrom
Conversation
9abb487 to
d32a2fb
Compare
Contributor
Author
|
Two tests fail in Running one locally I see: |
Contributor
Author
|
@jgraham - I'm not really sure what's going on here; I assume some Py3 bug in the websocket-over-http2 code, but I don't know where to start digging in. Test passes in Firefox on Py2. Test fails instantly in Chrome on Py2 or Py3 due to |
d32a2fb to
0e77b1f
Compare
Contributor
Author
|
Thanks for fixing this @jgraham ! PTAL, this PR should be good to go now. The Azure Pipelines failure is unrelated. |
Contributor
Author
|
Landed in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.