Test that dynamic import() is disallowed in paint worklets#26175
Merged
Test that dynamic import() is disallowed in paint worklets#26175
Conversation
3 tasks
domenic
force-pushed
the
worklet-dynamic-import
branch
from
b544084 to
496ce2e
Compare
annevk
reviewed
Dec 10, 2020
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Let's also update the README.md while here.
| try { | ||
| await import('./resources/imported-module.mjs'); | ||
| } catch (e) { | ||
| if (e.constructor === TypeError) { |
Member
There was a problem hiding this comment.
Should we also check .name as testharness.js seems to do?
Member
Author
There was a problem hiding this comment.
Eh, the only way .name would be different would be if someone mucked with TypeError.prototype.name, which seems unlikely?
annevk
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows whatwg/html#6070.