Replace os.path.split with .dirname or .basename where appropriate#25008
Replace os.path.split with .dirname or .basename where appropriate#25008
Conversation
wpt-pr-bot
added
annotation-protocol
css
eventsource
html
infra
localpaths.py
third_party
wg-annotation
wg-webapps
wptrunner
wpt-pr-bot
requested review from
Hexcles,
LukeZielinski,
Manishearth,
Yaffle,
annevk,
caitp,
domenic,
halindrome,
jdm,
kojiishi,
odinho,
plinss,
stephenmcgruer,
wisniewskit and
zcorpan
|
I believe that https://github.com/web-platform-tests/wpt/pull/25008/checks?check_run_id=984077316 can be ignored, these tests even say "Note: this test will only work as expected once per browsing session. Restart browser to re-test". @stephenmcgruer @jgraham I've seen this kind of stability failure many times, but this is the first time I've spotted it documented in the tests. Should we have some way of marking such tests as needing restart to avoid these failures? |
Hexcles
left a comment
Hexcles
left a comment
There was a problem hiding this comment.
Maybe we shouldn't touch tools/third_party?
Oops, I wasn't paying attention to where the changes were. |
Most of the changes made by: > git grep -lF os.path.split | xargs sed -i '' 's/os\.path\.split(\(.*\))\[0\]/os.path.dirname(\1)/g' That gets some things wrong, so all changes were vetted and some fixed or simplified.
wpt-pr-bot
requested review from
zqzhang
and removed request for
LukeZielinski
|
I've sent most of the tools/third_party changes in html5lib/html5lib-python#508 + GoogleChromeLabs/pywebsocket3#11 and reverted them here. |
|
Looking for regressions from this, it seems OK: @stephenmcgruer this is fewer failures due to flakiness than I remember typically seeing. Might that mean it's more feasible to label the remaining flakiness and make it possible to search excluding flaky tests? |
|
@foolip I think you more want https://wpt.fyi/results/?diff&filter=ADC&q=is%3Adifferent&run_id=657990001&run_id=661940001 Its still not huge (25 vs 50 subtests for Chrome, 10 vs 46 for Firefox), albeit this is only across two runs, but if we're saying flake is rare then it almost feels like a disincentive to add infrastructure around it rather than a reason to do it? |
|
I was looking for regressions and flakes were getting in the way. Filtering to just PASS→!PASS gets rid of the flakes that can't be regressions at least :) |
6 participants
Most of the changes made by:
That gets some things wrong, so all changes were vetted and some fixed
or simplified.