Skip to content

Workaround marionette 3.1.0 switch_to_window bug in Firefox 79#24992

Merged
stephenmcgruer merged 3 commits intomasterfrom
smcgruer/fix_marionette_driver_usage
Aug 13, 2020
Merged

Workaround marionette 3.1.0 switch_to_window bug in Firefox 79#24992
stephenmcgruer merged 3 commits intomasterfrom
smcgruer/fix_marionette_driver_usage

Conversation

@stephenmcgruer
Copy link
Contributor

Fixes #24924

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Aug 13, 2020
@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Aug 13, 2020

I intend to move this to a method on the protocol, and the documentation needs some work.

It's not clear to me still what exactly we're working around here; https://bugzilla.mozilla.org/show_bug.cgi?id=1588424 appears to state in https://bugzilla.mozilla.org/show_bug.cgi?id=1588424#c1 that geckodriver should support this already, and https://bugzilla.mozilla.org/show_bug.cgi?id=1588424#c7 implies we should just be on geckodriver 0.27.0 and maybe this wouldn't be a problem then?

But wanted to get a Firefox Stable run triggered, so starting with that :)

@jgraham
Copy link
Contributor

jgraham commented Aug 13, 2020

geckodriver isn't involved here, we're using the underlying marionette connection directly. It's just that marionette is very close to WebDriver in a way that e.g. CDP isn't.

Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24992 August 13, 2020 13:46 Inactive
@stephenmcgruer
Copy link
Contributor Author

geckodriver isn't involved here, we're using the underlying marionette connection directly. It's just that marionette is very close to WebDriver in a way that e.g. CDP isn't.

Ah, that makes sense. Thanks.

@stephenmcgruer
Copy link
Contributor Author

@stephenmcgruer
Copy link
Contributor Author

Stable run succeeded, and tests all are green except for an azure pipelines infra error. Merging.

@stephenmcgruer stephenmcgruer merged commit 7f2fac1 into master Aug 13, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/fix_marionette_driver_usage branch August 13, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra wptrunner The automated test runner, commonly called through ./wpt run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firefox stable daily runs are failing with NoSuchWindowException

4 participants