Conversation
We now have established a formal way to do this (more documentation will be available in Chromium, as this is Chrome-only) and should no longer accept these auto-generated files in WPT. Related to #16455.
stephenmcgruer
approved these changes
Aug 13, 2020
| MISSING DEPENDENCY: webusb/resources/usb-helpers.js | ||
| MISSING DEPENDENCY: webxr/resources/webxr_util.js | ||
|
|
||
| # TODO(Hexcles): delete these files once we include them in mojojs.zip. |
Contributor
There was a problem hiding this comment.
I don't support we have a bug tracking this on the Chromium side to link to? If not, not super important.
Co-authored-by: Stephen McGruer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have established a formal way to do this (more documentation will
be available in Chromium, as this is Chrome-only) and should no longer
accept these auto-generated files in WPT.
Related to #16455.