Conversation
* install_mojo is added to wpt.browser.Chrome and used automatically when running the nightly channel (only nightly is supported for now). * A new flag, --enable-mojojs, is added to wptrunner, which will map downloaded Mojo bindings to /gen/, and add necessary flags to Chrome. * In `wpt run`, if mojojs.zip is downloaded successfully, --enable-mojojs flag is added automatically when starting wptrunner.
wpt-pr-bot
added
infra
wpt
wptrunner
Contributor
LukeZielinski
left a comment
LukeZielinski
left a comment
There was a problem hiding this comment.
Nice!
I assume #24742 will fix the unit test problem, but should we also expect to see lots of additional passes on the wpt.fyi checks (which for some reason didn't really run on this PR)?
Member
Author
|
This only affects the newly added Chrome nightly, which isn't being scheduled at all right now. |
Member
Author
|
Tests now pass. |
LukeZielinski
approved these changes
Jul 27, 2020
Hexcles
added a commit
that referenced
this pull request
Aug 12, 2020
Automatically download mojojs.zip and turn on relevant flags for Chrome Dev. Follow-up to #24739.
Hexcles
added a commit
that referenced
this pull request
Aug 14, 2020
Automatically download mojojs.zip and turn on relevant flags for Chrome Dev. Follow-up to #24739.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when running the nightly channel (only nightly is supported for now).
downloaded Mojo bindings to /gen/, and add necessary flags to Chrome.
wpt run, if mojojs.zip is downloaded successfully,--enable-mojojs flag is added automatically when starting wptrunner.
(A bunch of drive-by auto style fixes are included, too.)
Test:
./wpt run --install-browser --channel=nightly chrome webxr/xrDevice_requestSession_immersive.https.htmlnow passes!