Test Symbol.toStringTag value of namespace objects#24717
Merged
domenic merged 3 commits intoweb-platform-tests:masterfrom Jul 23, 2020
Merged
Test Symbol.toStringTag value of namespace objects#24717domenic merged 3 commits intoweb-platform-tests:masterfrom
domenic merged 3 commits intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
requested review from
Ms2ger,
dbaron,
domenic,
domfarolino,
lilles,
plinss,
pwnall and
titzer
shvaikalesh
commented
Jul 23, 2020
Member
|
Per https://community-tc.services.mozilla.com/tasks/IPkLC1xwS2KAjIzOhr8DNg/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FIPkLC1xwS2KAjIzOhr8DNg%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log#L129 it looks like files in the CSS/ folder have extra requirements around some sort of link... try to look around nearby to see if we can figure that out? |
domenic
pushed a commit
to whatwg/webidl
that referenced
this pull request
Jul 23, 2020
A followup to #357. This change aligns WebIDL namespace objects with ECMA-262 ones, per tc39/ecma262#2057 (comment). Tests: web-platform-tests/wpt#24717
shvaikalesh
force-pushed
the
webidl-namespace-object-class-string
branch
from
6cb6d46 to
791d495
Compare
Member
Author
|
According to https://web-platform-tests.org/writing-tests/lint-tool.html, |
caiolima
pushed a commit
to caiolima/webkit-old
that referenced
this pull request
Aug 25, 2020
https://bugs.webkit.org/show_bug.cgi?id=215750 Reviewed by Ross Kirsling. LayoutTests/imported/w3c: Import ToT wpt/console tests including @@toStringTag tests. * resources/import-expectations.json: * web-platform-tests/console/META.yml: Added. * web-platform-tests/console/console-is-a-namespace.any-expected.txt: Added. * web-platform-tests/console/console-is-a-namespace.any.html: Added. * web-platform-tests/console/console-is-a-namespace.any.js: Added. (test): * web-platform-tests/console/console-is-a-namespace.any.worker-expected.txt: Added. * web-platform-tests/console/console-is-a-namespace.any.worker.html: Added. * web-platform-tests/console/console-label-conversion.any-expected.txt: Added. * web-platform-tests/console/console-label-conversion.any.html: Added. * web-platform-tests/console/console-label-conversion.any.js: Added. (const.method.of.methods.test): * web-platform-tests/console/console-label-conversion.any.worker-expected.txt: Added. * web-platform-tests/console/console-label-conversion.any.worker.html: Added. * web-platform-tests/console/console-namespace-object-class-string.any-expected.txt: Added. * web-platform-tests/console/console-namespace-object-class-string.any.html: Added. * web-platform-tests/console/console-namespace-object-class-string.any.js: Added. (test): (test.t.t.add_cleanup): * web-platform-tests/console/console-namespace-object-class-string.any.worker-expected.txt: Added. * web-platform-tests/console/console-namespace-object-class-string.any.worker.html: Added. * web-platform-tests/console/console-tests-historical.any-expected.txt: Added. * web-platform-tests/console/console-tests-historical.any.html: Added. * web-platform-tests/console/console-tests-historical.any.js: Added. (test): * web-platform-tests/console/console-tests-historical.any.worker-expected.txt: Added. * web-platform-tests/console/console-tests-historical.any.worker.html: Added. * web-platform-tests/console/idlharness.any-expected.txt: Added. * web-platform-tests/console/idlharness.any.html: Added. * web-platform-tests/console/idlharness.any.js: Added. * web-platform-tests/console/idlharness.any.worker-expected.txt: Added. * web-platform-tests/console/idlharness.any.worker.html: Added. * web-platform-tests/console/w3c-import.log: Added. Source/JavaScriptCore: Use "console" instead of "Console". Now, namespace object has @@toStringTag. web-platform-tests/wpt#24717 * runtime/ConsoleObject.cpp: LayoutTests: * fast/dom/Window/window-lookup-precedence-expected.txt: * fast/loader/window-properties-restored-from-page-cache-expected.txt: * http/tests/security/cross-frame-access-put-expected.txt: * inspector/debugger/pause-for-internal-scripts-expected.txt: * inspector/debugger/stepping/stepping-internal-scripts-expected.txt: * js/console-expected.txt: * js/console.html: * platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt: * platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
3 tasks
Leko
added a commit
to nodejs/node
that referenced
this pull request
Oct 1, 2020
Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: #35399 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 6, 2020
Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: #35399 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 3, 2020
Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: #35399 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 16, 2020
Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: #35399 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: nodejs#35399 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: whatwg/webidl#873.
Consensus: tc39/ecma262#2057 (comment).
cc @domenic