Test that BroadcastChannel settings object is current, not incumbent#24568
Merged
Test that BroadcastChannel settings object is current, not incumbent#24568
Conversation
3 tasks
annevk
reviewed
Jul 13, 2020
annevk
approved these changes
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #24566, but tests what origin is used for message-delivery filtering, which is the most important aspect of the BroadcastChannel settings object.
This tests my desired state, where the BroadcastChannel settings object can be eliminated and we use the relevant settings object instead. (Similar to what whatwg/html#5728 does for MessagePort.)
It appears that unlike MessagePort, where browsers all behave the same (but disagreed with the current spec), here Chrome has the simpler, desirable behavior while Firefox has the per-spec, complicated behavior.
Let's see what Safari does when the CI results come in!Safari doesn't support BroadcastChannel