Add test cases for URLSearchParams parsing %#24152
Merged
domenic merged 1 commit intoweb-platform-tests:masterfrom Jun 15, 2020
Merged
Add test cases for URLSearchParams parsing %#24152domenic merged 1 commit intoweb-platform-tests:masterfrom
domenic merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
requested review from
GPHemsley,
TimothyGu,
annevk,
domenic and
mikewest
domenic
approved these changes
Jun 15, 2020
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Looks great; thank you for contributing back!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds test cases from nodejs/node#33892 since it was mentioned it might be good to have these here.
Let me know if there are any changes that need to be made, I tested these locally against Firefox and Chrome and they look to be passing ok