[Gecko Bug 1624968] Make :host::part work in the same shadow tree as the part.#22715
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Apr 6, 2020
Merged
[Gecko Bug 1624968] Make :host::part work in the same shadow tree as the part.#22715moz-wptsync-bot merged 1 commit intomasterfrom
moz-wptsync-bot merged 1 commit intomasterfrom
Conversation
Differential Revision: https://phabricator.services.mozilla.com/D68249 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1624968 gecko-commit: d9643b5fb7607273103e006171c2ac2058708495 gecko-integration-branch: autoland gecko-reviewers: heycam
wpt-pr-bot
approved these changes
Apr 6, 2020
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 22, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 22, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 23, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 23, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 23, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 23, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 23, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 23, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 24, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 24, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
to servo/wpt
that referenced
this pull request
Jan 24, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
pushed a commit
that referenced
this pull request
Jan 24, 2026
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of #22715 Signed-off-by: Tim van der Lippe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D68249
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1624968
gecko-commit: d9643b5fb7607273103e006171c2ac2058708495
gecko-integration-branch: autoland
gecko-reviewers: heycam