Test entry and incumbent settings object for promise jobs#21206
Merged
Test entry and incumbent settings object for promise jobs#21206
Conversation
wpt-pr-bot
requested review from
annevk,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
3 tasks
domenic
changed the title
…ent. Finally made Chrome fail.
bzbarsky
approved these changes
Jan 24, 2020
|
|
||
| const thenable = { | ||
| // No t.step_func because that could change the realms | ||
| then(f) { |
Contributor
There was a problem hiding this comment.
Somewhere around here should we have a test where the then function of the thenable is effectively a scripted function from the incumbent global (perhaps runWindowPostMessageVeryIndirectly bound to some args)? Maybe it doesn't matter too much....
Member
Author
There was a problem hiding this comment.
I'm not sure I quite understand what this adds over the (2) suggested above (where the then function is from a different realm). Is using the incumbent global in particular important?
Firefox is kinda whiny without them
Ms2ger
added a commit
that referenced
this pull request
Jun 19, 2020
Substantially based on #21206. Ref: WebAssembly/spec#1184.
Ms2ger
added a commit
that referenced
this pull request
Jun 23, 2020
Substantially based on #21206. Ref: WebAssembly/spec#1184.
Ms2ger
added a commit
that referenced
this pull request
Jun 24, 2020
Substantially based on #21206. Ref: WebAssembly/spec#1184.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows whatwg/html#5212 which specifies entry, and throws in incumbent tests for good measure while we're here.
Chrome and Firefox both seem to pass these, which is somewhat surprising.