Skip to content

COOP/COEP: add META.yml#20843

Merged
zcorpan merged 6 commits intomasterfrom
zcorpan/coop-coep-meta-yml
Jan 10, 2020
Merged

COOP/COEP: add META.yml#20843
zcorpan merged 6 commits intomasterfrom
zcorpan/coop-coep-meta-yml

Conversation

@zcorpan
Copy link
Copy Markdown
Member

@zcorpan zcorpan commented Dec 18, 2019

No description provided.

domenic
domenic reviewed Dec 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add me :)

@jugglinmike
Copy link
Copy Markdown
Contributor

jugglinmike commented Dec 18, 2019

META.yml files present in all ancestor directories are also considered by the wpt-pr-bot. Since @domenic, @zcorpan, and @annevk are all listed in html/META.yml, including them here has no effect.

I can image alternate implementations where this would make a difference, so including those people here risks misleading others about how the wpt-pr-bot functions. We may want to lint for this.

@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Dec 19, 2019

How wpt-pr-bot functions might change with web-platform-tests/rfcs#37

But for now I can remove myself and annevk here.

@zcorpan zcorpan assigned mikewest and unassigned zqzhang Dec 19, 2019
mikewest
mikewest reviewed Dec 19, 2019
View reviewed changes
html/cross-origin-opener-policy/META.yml
spec: https://gist.github.com/annevk/6f2dd8c79c77123f39797f6bdac43f3e
suggested_reviewers:
- mikewest
- jugglinmike
Copy link
Copy Markdown
Member

@mikewest mikewest Dec 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding @arturjanc (or @lweichselbaum).

Copy link
Copy Markdown
Member Author

@zcorpan zcorpan Dec 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added both and invited them to the reviewers team. Artur & Lukas, welcome! You may want to unwatch this repo, filter emails and check the docs on reviewing tests. 🙂

@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Jan 8, 2020

Added @hemeryar and @ParisMeuleman per #20874 (comment)

@zcorpan zcorpan mentioned this pull request Jan 8, 2020
Merged
@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Jan 9, 2020

@valenting @JuniorHsu would you also like to be added here?

@valenting
Copy link
Copy Markdown
Contributor

valenting commented Jan 9, 2020

Yes, please add me too. Junior is on parental leave this month so he's unlikely to respond very soon.

@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Jan 9, 2020

@valenting thanks, I've added & invited you.

@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Jan 10, 2020

I'll merge this now so it starts having an effect. If someone wants to be removed, please comment here (or create a new PR).

Thanks!

@zcorpan zcorpan merged commit 1cc4aaa into master Jan 10, 2020
@zcorpan zcorpan deleted the zcorpan/coop-coep-meta-yml branch January 10, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikewest mikewest mikewest approved these changes

@domenic domenic domenic left review comments

@annevk annevk annevk approved these changes

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@mikewest mikewest

Labels

html

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zcorpan @jugglinmike @valenting @mikewest @domenic @annevk @zqzhang @wpt-pr-bot