Skip to content

[mediacapture-image] Execute subtests in series#20262

Open
jugglinmike wants to merge 1 commit intoweb-platform-tests:masterfrom
bocoup:mediacapture-image-test-in-series
Open

[mediacapture-image] Execute subtests in series#20262
jugglinmike wants to merge 1 commit intoweb-platform-tests:masterfrom
bocoup:mediacapture-image-test-in-series

Conversation

@jugglinmike
Copy link
Copy Markdown
Contributor

Subtests created with async_test execute in parallel. Because each
subtest in the modified file use the same canvas element, parallel
execution make them susceptible to undesired interactions.

Declare the subtests using promise_test so that the harness executes
them in series.


@reillyeon requested this change in gh-20234, where they wrote

Since the generated async tests are reusing the same <canvas> element
should they be converted to promise tests so that they run sequentially
rather than attempting to apply a bunch of different constraints in parallel?
That seems to depend on whether or not captureStream() is guaranteed to
return fully independent MediaStream instances.

These tests do not pass on my system (neither from master nor from this branch), so I can't verify the validity of this change.

Subtests created with `async_test` execute in parallel. Because each
subtest in the modified file use the same `canvas` element, parallel
execution make them susceptible to undesired interactions.

Declare the subtests using `promise_test` so that the harness executes
them in series.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants