[mediacapture-image] Execute subtests in series#20262
Open
jugglinmike wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
[mediacapture-image] Execute subtests in series#20262jugglinmike wants to merge 1 commit intoweb-platform-tests:masterfrom
jugglinmike wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
Subtests created with `async_test` execute in parallel. Because each subtest in the modified file use the same `canvas` element, parallel execution make them susceptible to undesired interactions. Declare the subtests using `promise_test` so that the harness executes them in series.
reillyeon
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtests created with
async_testexecute in parallel. Because eachsubtest in the modified file use the same
canvaselement, parallelexecution make them susceptible to undesired interactions.
Declare the subtests using
promise_testso that the harness executesthem in series.
@reillyeon requested this change in gh-20234, where they wrote
These tests do not pass on my system (neither from
masternor from this branch), so I can't verify the validity of this change.