[html] Include omitted script#20223
Merged
foolip merged 3 commits intoweb-platform-tests:masterfrom Nov 14, 2019
Merged
Conversation
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
gsnedders,
jdm,
jgraham,
zcorpan and
zqzhang
Contributor
Author
|
Turns out that file is procedurally generated. I learned this from a failing CI job, but it would be more helpful if the test material included a warning. In any event, I've updated the template, so those other tests now include an include. Unfortunately, now the task titled "wpt-firefox-nightly-results-without-changes" is failing. This seems unrelated to the patch, so I'll push up an empty commit to trigger another trial. |
foolip
approved these changes
Nov 14, 2019
Member
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
Looks sensible and CI is happy, so I'm happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ReferenceError that's thrown due to the absence of this script can cause some browsers to report unstable results. I'm going to discuss addressing that at the harness level, but this fix is straightforward enough that I thought we should apply it regardless.
There are a handful of other tests that include
test.jswithouttemplate.js, but none of them actually depend on that script.