Fix white logo to have a transparent background#19209
Closed
gsnedders wants to merge 1 commit intoweb-platform-tests:masterfrom
Closed
Fix white logo to have a transparent background#19209gsnedders wants to merge 1 commit intoweb-platform-tests:masterfrom
gsnedders wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
White text on a white background is rather useless.
zcorpan
requested changes
Sep 26, 2019
Member
zcorpan
left a comment
zcorpan
left a comment
There was a problem hiding this comment.
It has a transparent background. What you removed is the "underline" under the W, which is part of the logo.
Member
|
@jugglinmike something is wrong with update-pr-preview here: "403 Client Error: Forbidden for url: https://api.github.com/repos/web-platform-tests/wpt/issues/19209/labels". Perhaps a quota issue, is the token not being passed correctly everywhere? |
Member
|
Filed #19378 about that problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
White text on a white background is rather useless.