Fix css-shapes tests to load ahem as a web font and wait for fonts ready#19048
Fix css-shapes tests to load ahem as a web font and wait for fonts ready#19048LukeZielinski wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
|
@foolip @gsnedders Could you please take a look? Scanning over the results, this looks like a general improvement for both Chrome and Firefox. Safari is worse, likely because of the known document.fonts.ready timing issue on WebKit. One thing that is wrong with this change is that I see some test assertion failures getting returned as harness statuses (example). Any advice on how to address that? |
|
@LukeZielinski a failed assert turning into a harness error means that there's some code running outside of a test "step function". This is usually fixed by adding However, here
Can you rewrite to avoid |
|
@LukeZielinski also note that Ahem is still installed as a system font in our Safari config, so the |
|
@LukeZielinski this is conflicting now, can you rebase if this wasn't already fixed in another PR? |
|
Abandoning, this was fixed properly in #19577. Thanks for the ping. |
The font-related code is in a shared utility file for these tests. Updated it to load Ahem as a web font and wait for fonts.ready before running tests.
Adding these changes to the tests themselves didn't work, presumably because generate_tests is used and it interferes somehow.