Update idlharness to support constructor operations.#18722
Merged
Conversation
44 tasks
foolip
reviewed
Aug 29, 2019
foolip
approved these changes
Aug 29, 2019
4bd0ae0 to
8099e8a
Compare
Member
|
Ouch, this regressed all tests depending on html.idl. You can see it in https://github.com/web-platform-tests/wpt/runs/207949624 right on this PR but I didn't check that when reviewing. You can also see all the broken tests live on wpt.fyi. @web-platform-tests/wpt-core-team can someone quickly revert this? I don't have access to a computer with a command line this weekend, but can follow up with "stop this from happening again" types of bugs next week. @lukebjerring a case for regression detection here :) |
Member
|
What the failure saya:: This looks like a webidl2.js regression to me. |
Member
Member
|
I've filed w3c/webidl2.js#402. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See whatwg/webidl#778.