Add tests for 'form-associated custom elements'#15740
Merged
Conversation
wpt-pr-bot
requested review from
TakayoshiKochi,
domenic,
hayatoito,
kojiishi,
rniwa and
snuggs
This was referenced Mar 8, 2019
domenic
reviewed
May 15, 2019
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Sorry I missed this the first time through. Overall looking great.
custom-elements/form-associated/ElementInternals-setFormValue.html
Outdated
Show resolved
Hide resolved
custom-elements/form-associated/ElementInternals-validation.html
Outdated
Show resolved
Hide resolved
custom-elements/form-associated/ElementInternals-validation.html
Outdated
Show resolved
Hide resolved
wpt-pr-bot
requested review from
annevk,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
domenic
approved these changes
May 16, 2019
Member
|
r |
This is for WICG/webcomponents#187 Specification PR: whatwg/html#4383
- Rename callbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for WICG/webcomponents#187
Specification PR: whatwg/html#4383