HTML: target=_blank implies noopener; opener support#15188
Merged
Conversation
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
Member
Author
|
@foolip I don't know why Chrome is failing here. |
Member
|
From the logs: All results/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html
/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html
Unstable results
What is the runtime of the test, might it be close to timing out? |
Member
Author
|
It's opening a bunch of windows and reporting results via BroadcastChannel. Should be relatively quick, but might depend on other things? |
Member
|
I was able to reproduce the failure with I didn't time it, but each iteration seemed to take ~10s, and here's the output: All results/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html
Unstable results
Does the test run quickly on Firefox? |
Member
Author
|
It does. It shouldn't run any longer than the per-test timeout though. |
Member
|
I guess that one could only start trying to reproduce and minify until the cause is clear. Not sure who a good contact working on Chromium would be. @tkent-google, do you know who's are this is? |
domenic
reviewed
Feb 2, 2019
...emantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html
Outdated
Show resolved
Hide resolved
Contributor
If it's a Anyway, I have a comment on the test. |
tkent-google
reviewed
Feb 4, 2019
...emantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html
Outdated
Show resolved
Hide resolved
Member
Author
|
Should be all good now, from a test perspective. Dunno about Taskcluster though. |
Member
|
I'll go ahead and admin merge this. If it's also flaky in Chromium (content_shell) it'll be easier to diagnose there. |
Member
|
Uh, actually, whatwg/html#4330 is open. @annevk let me know when I should merge this. |
Member
Author
|
This can now be merged. I'll be merging the HTML PR shortly. A Chromium bug is already filed as per that PR. For squash and merge please only use the commit message from the initial commit. |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Feb 7, 2019
This reduces the number of coupled top-level browsing contexts and thereby reduces the attack surface somewhat. Tests: web-platform-tests/wpt#15188. Fixes #4078.
Member
|
@annevk squash merged! |
Member
Author
|
Takk! |
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
This reduces the number of coupled top-level browsing contexts and thereby reduces the attack surface somewhat. Tests: web-platform-tests/wpt#15188. Fixes whatwg#4078.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
This reduces the number of coupled top-level browsing contexts and thereby reduces the attack surface somewhat. Tests: web-platform-tests/wpt#15188. Fixes whatwg#4078.
Contributor
|
The test case does:
Is that valid? (It doesn't seem to create an image map, and there's a |
Member
|
|
Member
Author
|
It's indeed bogus, but shouldn't affect the test. I'll create a PR to clean that up a bit though. |
annevk
added a commit
that referenced
this pull request
May 27, 2019
As pointed out in #15188 (comment) it was a bit confusing (and wrong).
foolip
pushed a commit
that referenced
this pull request
May 27, 2019
As pointed out in #15188 (comment) it was a bit confusing (and wrong).
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 19, 2019
…ener tests, a=testonly Automatic update from web-platform-tests Editorial: cleanup some area opener/noopener tests (#17025) As pointed out in web-platform-tests/wpt#15188 (comment) it was a bit confusing (and wrong). -- wp5At-commits: 36f2a92acd0f8214dfcddfffd970f73c30efd5bf wpt-pr: 17025
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 19, 2019
…ener tests, a=testonly Automatic update from web-platform-tests Editorial: cleanup some area opener/noopener tests (#17025) As pointed out in web-platform-tests/wpt#15188 (comment) it was a bit confusing (and wrong). -- wp5At-commits: 36f2a92acd0f8214dfcddfffd970f73c30efd5bf wpt-pr: 17025
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
As pointed out in #15188 (comment) it was a bit confusing (and wrong).
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…ener tests, a=testonly Automatic update from web-platform-tests Editorial: cleanup some area opener/noopener tests (#17025) As pointed out in web-platform-tests/wpt#15188 (comment) it was a bit confusing (and wrong). -- wp5At-commits: 36f2a92acd0f8214dfcddfffd970f73c30efd5bf wpt-pr: 17025 UltraBlame original commit: b17abf34f8216da67984b02fd15a79f412aa5a9e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…ener tests, a=testonly Automatic update from web-platform-tests Editorial: cleanup some area opener/noopener tests (#17025) As pointed out in web-platform-tests/wpt#15188 (comment) it was a bit confusing (and wrong). -- wp5At-commits: 36f2a92acd0f8214dfcddfffd970f73c30efd5bf wpt-pr: 17025 UltraBlame original commit: b17abf34f8216da67984b02fd15a79f412aa5a9e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ener tests, a=testonly Automatic update from web-platform-tests Editorial: cleanup some area opener/noopener tests (#17025) As pointed out in web-platform-tests/wpt#15188 (comment) it was a bit confusing (and wrong). -- wp5At-commits: 36f2a92acd0f8214dfcddfffd970f73c30efd5bf wpt-pr: 17025 UltraBlame original commit: b17abf34f8216da67984b02fd15a79f412aa5a9e
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…ener tests, a=testonly Automatic update from web-platform-tests Editorial: cleanup some area opener/noopener tests (#17025) As pointed out in web-platform-tests/wpt#15188 (comment) it was a bit confusing (and wrong). -- wp5At-commits: 36f2a92acd0f8214dfcddfffd970f73c30efd5bf wpt-pr: 17025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For whatwg/html#4330.