Module scripts use same-origin credentials mode by default#13176
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Sep 26, 2018
Merged
Module scripts use same-origin credentials mode by default#13176chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Sep 23, 2018
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1239638
branch
3 times, most recently
from
431ffb0 to
7187550
Compare
Before this CL, module scripts via <script type=module> used "omit" as the default credentials mode. After this CL, "same-origin" is used. This extends to module script descendants as well. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/CUAxbvtnCh4. [email protected], [email protected], [email protected] Bug: 849101 Change-Id: I62617aafd3e226bc86459ec4a24138d9eac6e8ff Reviewed-on: https://chromium-review.googlesource.com/1239638 Reviewed-by: Kouhei Ueno <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Hiroki Nakagawa <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/master@{#594305}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1239638
branch
from
7187550 to
1e99374
Compare
Contributor
|
@domfarolino As far as I can tell, this test will now always fail in a UA that doesn't support the not-yet-final dynamic import proposal. Why was that change made? If we do want to test the dynamic import bits, shouldn't they be in a separate test, or at least a separate |
Contributor
|
(And in particular, the test became useless for the purpose of testing whether my fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1493449 is actually correct...) |
Member
|
Oh, I'm really sorry - that was a sloppy oversight. I'll move the dynamic import tests out to a separate file alongside the original. Apologies. |
Contributor
|
No need to apologize. I really appreciate you splitting those tests out! |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 3, 2018
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 --HG-- extra : moz-landing-system : lando
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 6, 2018
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 --HG-- extra : moz-landing-system : lando
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Oct 8, 2018
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
5 tasks
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 9, 2018
* Module scripts are always fetched with request credentials mode "same-origin" by default, instead of the previous default of "omit". Only worker module scripts can still set that to "omit", using the credentials option to the Worker constructor. Non-worker module scripts, which only have the crossorigin="" attribute available, can only toggle between "same-origin" and "include", similar to how crossorigin="" works for other platform features. * Similarly, import() statements inside of classic scripts now use the "same-origin" credentials mode, instead of "omit". This affects both <script> elements, where the default can be changed using crossorigin="", and other contexts like javascript: URLs and classic worker scripts, where the default cannot be changed. * The top-level script for module workers is always fetched with request mode "same-origin". Cross-origin workers did not quite work due to service workers. Fixes #2557. Fixes #3109. Tests: * web-platform-tests/wpt#11274 * web-platform-tests/wpt#13176 * web-platform-tests/wpt#13426
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
* Module scripts are always fetched with request credentials mode "same-origin" by default, instead of the previous default of "omit". Only worker module scripts can still set that to "omit", using the credentials option to the Worker constructor. Non-worker module scripts, which only have the crossorigin="" attribute available, can only toggle between "same-origin" and "include", similar to how crossorigin="" works for other platform features. * Similarly, import() statements inside of classic scripts now use the "same-origin" credentials mode, instead of "omit". This affects both <script> elements, where the default can be changed using crossorigin="", and other contexts like javascript: URLs and classic worker scripts, where the default cannot be changed. * The top-level script for module workers is always fetched with request mode "same-origin". Cross-origin workers did not quite work due to service workers. Fixes whatwg#2557. Fixes whatwg#3109. Tests: * web-platform-tests/wpt#11274 * web-platform-tests/wpt#13176 * web-platform-tests/wpt#13426
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
* Module scripts are always fetched with request credentials mode "same-origin" by default, instead of the previous default of "omit". Only worker module scripts can still set that to "omit", using the credentials option to the Worker constructor. Non-worker module scripts, which only have the crossorigin="" attribute available, can only toggle between "same-origin" and "include", similar to how crossorigin="" works for other platform features. * Similarly, import() statements inside of classic scripts now use the "same-origin" credentials mode, instead of "omit". This affects both <script> elements, where the default can be changed using crossorigin="", and other contexts like javascript: URLs and classic worker scripts, where the default cannot be changed. * The top-level script for module workers is always fetched with request mode "same-origin". Cross-origin workers did not quite work due to service workers. Fixes whatwg#2557. Fixes whatwg#3109. Tests: * web-platform-tests/wpt#11274 * web-platform-tests/wpt#13176 * web-platform-tests/wpt#13426
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 UltraBlame original commit: 2de25096cdd54c32488a4d5fdb1fefce6d1fb6db
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 UltraBlame original commit: e2ec1eeb812d2a3178c303e9ba5538e0d2264bec
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 UltraBlame original commit: 2de25096cdd54c32488a4d5fdb1fefce6d1fb6db
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 UltraBlame original commit: e2ec1eeb812d2a3178c303e9ba5538e0d2264bec
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 UltraBlame original commit: 2de25096cdd54c32488a4d5fdb1fefce6d1fb6db
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 UltraBlame original commit: e2ec1eeb812d2a3178c303e9ba5538e0d2264bec
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
May 29, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
May 30, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
May 30, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
May 30, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
May 31, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
May 31, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 1, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 1, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 1, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 2, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 2, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 3, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 3, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 3, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 11, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 13, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 17, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 17, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 17, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 21, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jun 23, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jul 23, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jul 29, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
buttercookie42
pushed a commit
to buttercookie42/Waterfox-Classic
that referenced
this pull request
Jul 29, 2022
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
gcp
pushed a commit
to gcp/enterprise-firefox-old
that referenced
this pull request
Feb 18, 2026
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
gcp
pushed a commit
to gcp/enterprise-firefox-old
that referenced
this pull request
Feb 18, 2026
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this CL, module scripts via <script type=module> used "omit" as
the default credentials mode. After this CL, "same-origin" is used. This
extends to module script descendants as well. Intent to implement and
ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/CUAxbvtnCh4.
R=[email protected], [email protected], [email protected]
Bug: 849101
Change-Id: I62617aafd3e226bc86459ec4a24138d9eac6e8ff
Reviewed-on: https://chromium-review.googlesource.com/1239638
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#594305}