[css-typed-om] support pointer-events property#10102
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 20, 2018
Merged
[css-typed-om] support pointer-events property#10102chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Mar 20, 2018
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
Build PASSEDStarted: 2018-03-20 00:47:50 View more information about this build on: |
pointer-events[1] are added to support in whitelist. there are some camelcase keywords in pointer-events. actually pre-defined keywords are interpreted ASCII case-insensitively[2]. so it was changed to accept camelcase keyword in tests. and test file are also added. [1]https://svgwg.org/svg2-draft/interact.html#PointerEventsProperty [2]https://drafts.csswg.org/css-values-4/#keywords Bug: 820299 Change-Id: Iccc0f88a69bbec68964ef55bcc5c471fea765ccf Reviewed-on: https://chromium-review.googlesource.com/968581 Reviewed-by: Darren Shen <[email protected]> Commit-Queue: Hwanseung Lee <[email protected]> Cr-Commit-Position: refs/heads/master@{#544232}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-968581
branch
from
8b187db to
017de5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pointer-events[1] are added to support in whitelist.
there are some camelcase keywords in pointer-events.
actually pre-defined keywords are interpreted
ASCII case-insensitively[2].
so it was changed to accept camelcase keyword in tests.
and test file are also added.
[1]https://svgwg.org/svg2-draft/interact.html#PointerEventsProperty
[2]https://drafts.csswg.org/css-values-4/#keywords
Bug: 820299
Change-Id: Iccc0f88a69bbec68964ef55bcc5c471fea765ccf
Reviewed-on: https://chromium-review.googlesource.com/968581
Reviewed-by: Darren Shen [email protected]
Commit-Queue: Hwanseung Lee [email protected]
Cr-Commit-Position: refs/heads/master@{#544232}